This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 20751 - IDE should refuse System.exit unless called from NbTopManager.exit
Summary: IDE should refuse System.exit unless called from NbTopManager.exit
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Execution (show other bugs)
Version: 3.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: Petr Hrebejk
URL:
Keywords:
Depends on:
Blocks: 9953 20204 32820
  Show dependency tree
 
Reported: 2002-02-21 13:38 UTC by Jesse Glick
Modified: 2008-12-23 13:36 UTC (History)
6 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
Proposed patch (5.55 KB, patch)
2002-02-22 12:18 UTC, Jesse Glick
Details | Diff
Thread dump with NB 6.1 (20.33 KB, text/plain)
2008-07-18 13:58 UTC, toniomack
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2002-02-21 13:38:28 UTC
I.e. TopSecurityManager should block all exit calls unless a flag is set that
NbTM.exit is being called. This should improve robustness.
Comment 1 Jesse Glick 2002-02-21 13:47:31 UTC
Candidate for inclusion in Orion, I suppose.
Comment 2 Jesse Glick 2002-02-22 12:18:16 UTC
Created attachment 4794 [details]
Proposed patch
Comment 3 Jesse Glick 2002-02-22 12:22:49 UTC
The attached patch (against release33 sources) appears to solve
#20204. When Help | Help Sets | <<your bogus help set here>> is
selected (I tried messing up usersguide to include a mistyped search
database name in ide.hs), an exception dialog appears, and the details
include information about the help set error sufficient to debug it.
The rest of the IDE is unaffected and can continue to be used.

I will apply this patch to the trunk soon. Let me know if and when it
should be applied to release33 or some FFJ-specific branch.

The patch is simple enough and I believe safe; reviews welcome.
Comment 4 Jesse Glick 2002-02-22 12:53:11 UTC
Possible candidate for pre-3.4 patch; needs to be tested & evaluated,
remove keyword if desired.
Comment 5 Jesse Glick 2002-02-25 12:15:04 UTC
Fixed in trunk.

committed   * Up-To-Date  1.138      
core/src/org/netbeans/core/NbTopManager.java
committed   * Up-To-Date  1.59       
core/src/org/netbeans/core/NonGui.java
committed   * Up-To-Date  1.8        
core/src/org/netbeans/core/NonGuiMain.java
committed   * Up-To-Date  1.49       
core/src/org/netbeans/core/execution/TopSecurityManager.java
Comment 6 _ ttran 2002-03-05 09:16:07 UTC
The diff looks sane to me.  Consider it reviewed
Comment 7 Bob May 2002-03-12 18:28:23 UTC
Assuming there is a 3.3.2, it would be helpful if this patch were in
there so it could be included in Orion FCS. Thank you for the patch.
Comment 8 Jan Zajicek 2002-03-21 14:58:10 UTC
Tested and verified. Will mark this as verified after commit into 3.3.2.
Comment 9 Jesse Glick 2002-03-21 15:49:23 UTC
x
Comment 10 Jesse Glick 2002-03-21 15:50:06 UTC
-> Petr for physical integration.
Comment 11 Jesse Glick 2002-03-21 15:50:34 UTC
x
Comment 12 Petr Hrebejk 2002-03-22 15:46:10 UTC
Integrated into orion_fcs branch
Comment 13 Jan Zajicek 2002-03-26 12:05:08 UTC
Verified in FFJ40.
Comment 14 Quality Engineering 2003-07-01 16:45:58 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.
Comment 15 toniomack 2008-07-18 13:58:27 UTC
Created attachment 64957 [details]
Thread dump with NB 6.1
Comment 16 Jesse Glick 2008-07-18 19:04:03 UTC
toniomack's thread dump was intended for issue #138196.