This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 207136 - Discard on close TC; asked again when IDE close
Summary: Discard on close TC; asked again when IDE close
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 7.2
Hardware: PC Windows XP
: P2 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
: 206383 207561 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-01-10 17:37 UTC by err
Modified: 2012-02-15 13:09 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description err 2012-01-10 17:37:44 UTC
To reproduce:

- start IDE, open a java file
- make a change to the file, DO NOT SAVE
- close editor TC; DISCARD the changes
- close IDE
Observe that it asks again if the changes should be discarded.

I discovered this when verifying Bug 205835. That bug is fixed, but perhaps the fix for that bug introduced this problem. 7.1 does *not* have this problem.

Product Version: NetBeans IDE Dev (Build 201201090601)
Java: 1.6.0_23; Java HotSpot(TM) Client VM 19.0-b09
System: Windows XP version 5.1 running on x86; Cp1252; en_US (nb)
Comment 1 Marian Mirilovic 2012-01-10 21:21:17 UTC
If this is connected with issue 205835, it has to be fixed also in release71_fixes branch to deliver it as a part of Patch 1 for NB 7.1 end users.
Comment 2 Jiri Skrivanek 2012-01-11 07:13:47 UTC
If evaluated as a bug in datasystems, please close the bug 206383 as a duplicate.
Comment 3 Jaroslav Tulach 2012-01-16 12:00:11 UTC
When pressing discard (as displayed by core.multiview API), the editor, editor support and data objects are not notified and are not marked as unmodified.
Comment 4 Jaroslav Tulach 2012-01-16 14:29:35 UTC
ergonomics#d28f9baca269
Comment 5 Jaroslav Tulach 2012-01-16 14:41:32 UTC
*** Bug 206383 has been marked as a duplicate of this bug. ***
Comment 6 Quality Engineering 2012-01-17 16:11:32 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/d28f9baca269
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #207136: As soon as last editor is closed, mark the document unmodified
Comment 7 Jaroslav Tulach 2012-01-17 16:42:01 UTC
Please verify.
Comment 8 Jiri Skrivanek 2012-01-18 09:12:54 UTC
Case from bug 206383 not fixed. Steps:

- start IDE
- create java project
- type something in JavaApplication1.java file
- close editor
- choose Discard in question dialog
- open JavaApplication1.java again but previously written content is not discarded. But if you restart IDE and open JavaApplication1.java, new content mysteriously disappears.

Product Version: NetBeans IDE Dev (Build 201201170601)
Java: 1.7.0_02; Java HotSpot(TM) Client VM 22.0-b10
System: Windows XP version 5.1 running on x86; Cp1250; en_US (nb)
Comment 9 err 2012-01-18 14:48:26 UTC
(In reply to comment #8)
> Case from bug 206383 not fixed. Steps:
> ...
> Product Version: NetBeans IDE Dev (Build 201201170601)
> Java: 1.7.0_02; Java HotSpot(TM) Client VM 22.0-b10
> System: Windows XP version 5.1 running on x86; Cp1250; en_US (nb)

The fix went into main-golden at "2012-01-17 16:11:32". AFAIK, the fix is not in the IDE you tested.

This mornings DEV build, 2012-01-17-0601, also does not include the fix.
Comment 10 err 2012-01-19 18:07:56 UTC
Comment 8 is correct; those steps produce the indicated failure.

Product Version: NetBeans IDE Dev (Build 201201180601)
Java: 1.7.0_02; Java HotSpot(TM) Client VM 22.0-b10
Comment 11 Jaroslav Tulach 2012-01-23 15:34:00 UTC
ergonomics#385f17a96939
Comment 12 Jaroslav Tulach 2012-01-24 08:16:53 UTC
Yet more tweak in ergonomics#843c796b39da
Comment 13 Marian Mirilovic 2012-01-24 14:54:21 UTC
Ok, so please once this is verified in trunk, transplant fix into release71_fixes as well. Thanks in advance.
Comment 14 Marian Mirilovic 2012-01-24 15:04:12 UTC
*** Bug 207561 has been marked as a duplicate of this bug. ***
Comment 15 Quality Engineering 2012-01-25 16:29:52 UTC
Integrated into 'main-golden', will be available in build *201201250600* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/385f17a96939
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #207136: We need to discard old content, when last editor is closed
Comment 16 err 2012-01-25 16:34:50 UTC
Question: Is there a way to determine if a particular change is in a given daily build?
Comment 17 Jiri Skrivanek 2012-01-26 08:57:22 UTC
Verified in build 201201250600.
Comment 18 Jaroslav Tulach 2012-01-26 09:33:53 UTC
Fixed in release71_fixes: http://hg.netbeans.org/releases/rev/689d0eade021
Comment 19 Tomas Danek 2012-02-15 13:09:41 UTC
unable to reproduce none of mentioned testcases - verified in 
Product Version: NetBeans IDE 7.1.1 RC1 (Build 201202132200)
Java: 1.6.0_29; Java HotSpot(TM) 64-Bit Server VM 20.4-b02-402
System: Mac OS X version 10.7.3 running on x86_64; MacRoman; en_US (nb)
User directory: /Users/tomas/.netbeans/7.1.1rc1
Cache directory: /Users/tomas/.netbeans/7.1.1rc1/var/cache