This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 206479 - API method for invoking AddServerInstanceWizard
Summary: API method for invoking AddServerInstanceWizard
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 7.1
Hardware: All All
: P3 normal (vote)
Assignee: Martin Fousek
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2011-12-16 14:40 UTC by Martin Fousek
Modified: 2011-12-23 08:32 UTC (History)
3 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
api change including usage - v1 (7.20 KB, patch)
2011-12-16 14:44 UTC, Martin Fousek 		Details | Diff
api change including usage - v2 (7.19 KB, patch)
2011-12-16 16:38 UTC, Martin Fousek 		Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Fousek 2011-12-16 14:40:07 UTC 
There is missing method outside JavaEE area to invoke wizard for new server creation. Attached patch contains also usage within coherence module. Anyway this method should be valuable for any non-JavaEE server, I think.
Comment 1 Martin Fousek 2011-12-16 14:44:13 UTC 
Created attachment 114269 [details]
api change including usage - v1
Comment 2 Martin Fousek 2011-12-16 14:47:11 UTC 
Please review.
Comment 3 Petr Hejl 2011-12-16 16:17:38 UTC 
PH01: The name showCreateNewServerCustomizer seems to be overcomplicated. And it is not really a customizer. Why not just showWizard(), showServerInstanceWizard() or showAddServerInstanceWizard().
PH02: Assert message "Can lead to invocation of the UI dialog outside EDT" contradicts the assert. "Invocation of the UI dialog outside of the EDT" is clean and simple.
Comment 4 Martin Fousek 2011-12-16 16:38:39 UTC 
Created attachment 114270 [details]
api change including usage - v2

(In reply to comment #3)
> PH01: The name showCreateNewServerCustomizer seems to be overcomplicated. And
> it is not really a customizer. Why not just showWizard(),
> showServerInstanceWizard() or showAddServerInstanceWizard().

Right, badly chosen name before. :/

> PH02: Assert message "Can lead to invocation of the UI dialog outside EDT"
> contradicts the assert. "Invocation of the UI dialog outside of the EDT" is
> clean and simple.

Fixed.
Comment 5 Martin Fousek 2011-12-22 13:36:34 UTC 
Thanks for the review. I plan to integrate the change today COB.
Comment 6 Martin Fousek 2011-12-22 15:42:16 UTC 
Integrated in web-main #243ec3bf85a3.
Comment 7 Quality Engineering 2011-12-23 08:32:31 UTC 
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/243ec3bf85a3
User: Martin Fousek <marfous@netbeans.org>
Log: #206479 - API method for invoking AddServerInstanceWizard