This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 206194 - static API method UI.invokeAfterScanFinished
Summary: static API method UI.invokeAfterScanFinished
Status: RESOLVED INVALID
Alias: None
Product: java
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 7.2
Hardware: PC Mac OS X
: P3 normal (vote)
Assignee: Jan Becicka
URL:
Keywords: API_REVIEW, API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2011-12-09 14:04 UTC by Jan Becicka
Modified: 2011-12-12 08:18 UTC (History)
2 users (show)

See Also:
Issue Type: TASK
Exception Reporter:

Attachments
Proposed patch (8.72 KB, patch)
2011-12-09 14:14 UTC, Jan Becicka 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Becicka 2011-12-09 14:04:06 UTC 
Please review attached patch
Comment 1 Jan Becicka 2011-12-09 14:14:27 UTC 
Created attachment 114003 [details]
Proposed patch
Comment 2 Jesse Glick 2011-12-09 15:55:27 UTC 
[JG01] Is there some reason this is not in, say, java.sourceui or parsing.api? It does not seem to use anything in refactoring.java (other than a suspicious use of bundle keys from outside the package).
Comment 3 Jan Becicka 2011-12-09 16:54:01 UTC 
[JG01] the only request is from refactoring afaik. this is the reason
Comment 4 Jesse Glick 2011-12-09 17:11:23 UTC 
JG01 - that is what I guessed, but if there is no inherent reason why an API cannot be placed in a more basic module, and you can foresee possible uses from non-refactoring-related code, then it seems strange to put it where you did.
Comment 5 Jan Lahoda 2011-12-09 17:16:28 UTC 
JL01 (JG01 cont'ed): What is the relation to java.sourceui's ScanDialog.runWhenScanFinished? The javadoc seems very similar, if not the same, and the impl. is also somewhat similar. ScanDialog.runWhenScanFinished is used on a couple of places in NetBeans proper:
http://lahoda.info/index/usages/search?path=netbeans-indexing&signatures=METHOD:org.netbeans.api.java.source.ui.ScanDialog:runWhenScanFinished:%28Ljava/lang/Runnable;Ljava/lang/String;%29Z
Comment 6 Tomas Zezula 2011-12-12 07:33:02 UTC 
The java source ui module already provides such a method:

org.netbeans.api.java.source.ui.ScanDialog.runWhenScanFinished
Comment 7 Jan Becicka 2011-12-12 08:18:42 UTC 
looks like the method was already copied to proper place, but was not removed from refactoring. Thanks for review.