This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 20570 - NbPresenter does not make large messages scrollable
Summary: NbPresenter does not make large messages scrollable
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: Sun SunOS
: P2 blocker (vote)
Assignee: _ ttran
URL:
Keywords:
Depends on:
Blocks: 21041 22915 22925
  Show dependency tree
 
Reported: 2002-02-14 23:01 UTC by Torbjorn Norbye
Modified: 2008-12-23 13:41 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Screenshot showing the problem with the module disable confirm dialog (117.53 KB, image/gif)
2002-02-14 23:02 UTC, Torbjorn Norbye
Details
binary jar patch for release33/orion_fcs, put it in lib/patches (14.98 KB, application/octet-stream)
2002-04-04 15:05 UTC, _ ttran
Details
diff against release33/orion_fcs (2.23 KB, patch)
2002-04-04 15:06 UTC, _ ttran
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Torbjorn Norbye 2002-02-14 23:01:28 UTC
I'm running Forte Enterprise Edition, which has a huge number of modules.
I want to disable most of them, since I'm only using a few of them.
I use the Setup Wizard for that.

When I press Finish, I get this dialog telling me that in order to disable
(module list here), I have to also disable (other module list here).

Since I've disabled 20 modules or more (or, if I've disabled one key module,
such as say the basic java support module, such that the "must also disable"
list is long), the resulting dialog is too tall to show on my desktop. Thus
the "OK" button is off screen. I had spent 20 minutes customizing my module
selection (like I said, Enterprise Edition has a large number of modules!,
and with the combobox boolean selector it takes multiple keypresses for each
disable operation) so this is a bit annoying.

I think the contents needs to be put inside a scrollpane.

See screenshot for an example of what I mean. (I will attach that next).
Comment 1 Torbjorn Norbye 2002-02-14 23:02:30 UTC
Created attachment 4710 [details]
Screenshot showing the problem with the module disable confirm dialog
Comment 2 Jesse Glick 2002-02-15 11:04:49 UTC
It's a problem, all right. ModulesBean just creates a
NotifyDescriptor.Confirmation with a long string. NbPresenter is
responsible for physically laying it out in a dialog. Of course
ModulesBean could work around this if necessary by creating a Swing
component (textarea?) in a scrollpane, but it would be preferable if
NbPresenter handled this sort of thing more generally, I guess.
Comment 3 _ ttran 2002-02-28 15:55:14 UTC
anyone already working on it?  I am taking over.
Comment 4 _ ttran 2002-02-28 16:07:08 UTC
a JScrollPane is inserted in between iff the preferredSize of the
message pane either has the width > 600 or height > 400.

The result does not look very pretty, but if you have so many
charaters in the message text it's already ugly.  At least now the
dialog is usable.

Comment 5 Marian Mirilovic 2002-03-01 09:38:33 UTC
It seems like fix of this issue caused issue 21041.
Comment 6 _ ttran 2002-04-03 07:04:29 UTC
someone (jchalupa?) added 3.3.2_CANDIDATE keyword.  Justification?
Comment 7 Jan Chalupa 2002-04-03 08:32:18 UTC
Yes, I've attached the keyword. It seemed to me that the fix was not
complicated and might improve the user's experience (especially when
the user needs to customize a product consisting of many modules such
as FFJ). Also, the bug is a P2 so it seemed to be a good candidate for
fixing in the next bugfix release.

Feel free to push back if you disagree.
Comment 8 _ ttran 2002-04-03 11:27:38 UTC
> It seemed to me that the fix was not complicated

only that I created a significant regression (issue 21041) during
fixing this bug <sigh>
Comment 9 Torbjorn Norbye 2002-04-03 17:30:29 UTC
For FFJ-EE the module number is so large that this bug is a lot
more likely to occur. We're pushing module-disablement as the
primary performance-tuning method when users complain about
slow performance. With this bug that's problematic.
Comment 10 _ ttran 2002-04-04 15:05:06 UTC
Created attachment 5295 [details]
binary jar patch for release33/orion_fcs, put it in lib/patches
Comment 11 _ ttran 2002-04-04 15:06:03 UTC
Created attachment 5296 [details]
diff against release33/orion_fcs
Comment 12 _ ttran 2002-04-04 15:08:14 UTC
Please test the patch for release33/orion.  Dangerous change, affects
every Dialogs/Wizards in the IDE
Comment 13 Jan Zajicek 2002-04-05 12:00:58 UTC
Patch verified in EE020404_2. Any regression such as 21041 wasn't
observed.
Comment 14 _ ttran 2002-04-05 12:39:55 UTC
integ'ed into orion_fcs
Comment 15 Jan Zajicek 2002-04-09 13:45:53 UTC
verified in 020408_1
Comment 16 Quality Engineering 2003-07-01 16:25:55 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.