Created attachment 113453 [details]
CTL_SmallIcons can be empty - then the releated UI is hidden
Some applications may want to use only single size icons in toolbar. For them it does not make sense to have a checkbox in the toolbar configuration popup menu.
Let's allow applications on top of NetBeans Platform to disable the checkbox.
[JG01] Why the diff to Bundle.properties? Seems to just be moving a key to a different part of the file for no clear reason.
[JG02] Suggestion - rather than this rather obscure trick, it would be more natural to read the list of context menu items for the toolbar from a particular layer location, and read it using actionsForPath/actionsToPopup as usual. (Even more simply, just use File/View/Toolbars/ so the main menu presenter comes for free; you still need aFP/aTP to create the popup on the toolbar itself.) core.windows would define four entries (not counting separators):
1. A DynamicMenuContent yielding one checkbox menu item per known toolbar.
2. "Small Toolbar Icons"
3. "Reset Toolbars"
and any app wishing to remove one or more of these could mask it out in the usual way. Indeed, any module could add its own items here - which would perhaps be a more natural place for the editor module to place "Show Editor Toolbar".
[JG02] +1 - i'm sure there will be more customizations needed for jdev integration so this would make them much easier
Re. JG01 - it actually removes one key. It unifies the text of the action as well as checkbox.
Re. JG02 - OK, I'll try that.
Re. JG02 - but I need to modify the layout of the dialog, I don't think layer is appropriate place for doing that.
(In reply to comment #4)
> I need to modify the layout of the dialog
Sorry, not following - what dialog?
Better not use apireviews as an assignee any more; BZ does not seem to be happy with it, and this has resulted in a couple dozen apparently abandoned issues.
"Customize Toolbar" dialog has a checkbox which needs to disappar as well. Branding is an easy way to do it. Using a layer might be seen unnatural, am I right?
OK, I did not see that part of the patch. It is true this would not follow naturally from branding out the menu item.
If you prefer to use branding, I would just suggest an explicit key with a boolean value for enabling or disabling small icons. Seems less magical than testing for an empty label on a checkbox.
OK, seems like branding style approved.
I prefer one shared key to brand to two or three independent ones. Will help to keep consistency.
I plan to integrate tomorrow.
Integrated into 'main-golden'
User: Jaroslav Tulach <firstname.lastname@example.org>
Log: #205464: One can disable 'small icons' checkboxes via branding