This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 205355 - Views of attached Mercurial diffs lose original information
Summary: Views of attached Mercurial diffs lose original information
Status: RESOLVED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Bugzilla (show other bugs)
Version: 7.1
Hardware: PC Linux
: P3 normal (vote)
Assignee: Marco Walther
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2011-11-21 13:34 UTC by Jesse Glick
Modified: 2011-11-21 22:12 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2011-11-21 13:34:47 UTC
Consider bug #203477 comment #17 and discussion in #20. The BZ page links to [1] which Martin and I consider unreadable. You might click "Raw Unified" to go to [2] thinking you are seeing the original attachment, but you are not; for example, the last hunk is labeled

--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ d687683b8aa7	Mon Nov 21 11:35:59 2011 +0100

with no mention of a file name, which is clearly bogus. (Seems it is confused by Mercurial's diff format, and I am guessing it would be just as confused by Git's.) You need to rather click "View" to just see the original diff as uploaded [3].

Regression from recent BZ upgrade; the previous version would just show the originally uploaded file as text/plain, which was fine.


[1] http://netbeans.org/bugzilla/attachment.cgi?id=113360&action=diff
[2] http://bugzilla-attachments-203477.netbeans.org/bugzilla/attachment.cgi?id=113360&action=diff&collapsed=&context=patch&format=raw&headers=1
[3] http://bugzilla-attachments-203477.netbeans.org/bugzilla/attachment.cgi?id=113360
Comment 1 Marco Walther 2011-11-21 21:30:58 UTC
Fixed.
Comment 2 Jesse Glick 2011-11-21 21:44:22 UTC
I do not see any change; what specifically was fixed, and is it still in staging?
Comment 3 Jesse Glick 2011-11-21 22:12:18 UTC
> * The `diff view' should show better (maybe needs a Shift-Reload),
> that was a bad interaction between the original BZ CSS & the NB additions
> * The `Raw View' should now work as well, even for added files.
>
> No, it's @ netbeans.org 

Needed to force reload. Now it looks better.