This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 204686 - Updated IDE on 4th Nov 2011 and now the 'comment'/'uncomment' buttons no longer add/remove comments from my php/html files.
Summary: Updated IDE on 4th Nov 2011 and now the 'comment'/'uncomment' buttons no long...
Status: VERIFIED FIXED
Alias: None
Product: php
Classification: Unclassified
Component: Editor (show other bugs)
Version: 7.1
Hardware: PC Windows XP
: P2 normal (vote)
Assignee: Petr Pisl
URL:
Keywords:
: 204964 (view as bug list)
Depends on: 204452 199823
Blocks:
  Show dependency tree
 
Reported: 2011-11-04 14:55 UTC by PaulBrewster
Modified: 2011-12-01 17:15 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
html/javascrip file (3.95 KB, text/html)
2011-11-09 14:42 UTC, PaulBrewster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description PaulBrewster 2011-11-04 14:55:37 UTC
Product Version = NetBeans IDE Dev (Build nbms-and-javadoc-7954-on-20110922)
Operating System = Windows XP version 5.1 running on x86
Java; VM; Vendor = 1.6.0_26
Runtime = Java HotSpot(TM) Client VM 20.1-b02
Comment 1 Ondrej Brejla 2011-11-07 09:38:51 UTC
Maybe it's regression after the fix of http://netbeans.org/bugzilla/show_bug.cgi?id=198269 ?
Comment 2 Ondrej Brejla 2011-11-07 11:16:47 UTC
It's quite strange...if I remove Petr's change, it still doesn't work. I have todays build, same as Tomas has, and it works for him...
Comment 3 Ondrej Brejla 2011-11-07 13:29:47 UTC
Commenting works with ctrl+shift+c shortcut (or ctrl+/)
Comment 4 PaulBrewster 2011-11-07 18:03:17 UTC
Neither ctrl+shift+c or ctrl+/ work with php or html.
Comment 5 Ondrej Brejla 2011-11-08 09:04:10 UTC
ctrl+shift+c really works for me for plain .php file, .phtml files (mixed html+php)...and for html files as well.
Comment 6 Petr Pisl 2011-11-08 14:21:14 UTC
At first I will clarify the situation of the fix for issue #198269. 

There are two parts of the fix. The first is in csl infrastructure. It prevents to register ToggleBlockCommentAction  text/x-php5 mimetype. The second one is a new action ToggleBlockCommentAction that is registered for text/x-php5 mimetype separately. This action just try to find a case, where on the first line is php delimiter, in other cases delegate back to the infrastructure. 

During the fixing I didn't noticed, that the Comment and Uncomment stoped to work. They doesn't work, because use different calling mechanism then calling the action through the shortcut CTRL+/. This should work.

The fix should affects only .php and .phtml files, not other files. 

PaulBrewster, could you please confirm this?

To get the buttons work properly, there have to be fixed issue #199823 and implemented issue #204452. Without these fixes I can not do basically nothing, except removing my fix. 

So, I increase the priority of this issue to P2, because it should be solved in the final build and set up that it depends on issue #199823 and issue #204452. Also I have committed small change http://hg.netbeans.org/web-main/rev/dcd2454841de , that should reflect the functionality of the buttons. 

If the issuess #199823 and #204452, will not be solved, then we will have to remove fix for issue #198269 and reopened it.
Comment 7 PaulBrewster 2011-11-08 15:06:11 UTC
I have an html file with no php in it, just html tags and javascript.  The buttons do not work on this file.  The Ctrl+/ and Ctrl+Shift+C shortcuts do not work either.
Comment 8 Petr Pisl 2011-11-09 14:10:06 UTC
Could you please attach such file and say in which position doesn't work? Thanks
Comment 9 PaulBrewster 2011-11-09 14:42:14 UTC
Created attachment 113049 [details]
html/javascrip file

Here's the file.  The comment/uncomment buttons work fine on the .css file called by this one.
Comment 10 Petr Pisl 2011-11-09 15:25:35 UTC
This is .inc file, what is basically the same as .php file from NetBeans point of view. It has the same mimetype (icon, all actions, etc.) . So this is OK. It will be fixed as I have described above. Thanks. No it's clear.
Comment 11 Quality Engineering 2011-11-09 16:08:42 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/dcd2454841de
User: Petr Pisl <ppisl@netbeans.org>
Log: #204686 - Updated IDE on 4th Nov 2011 and now the 'comment'/'uncomment' buttons no longer add/remove comments from my php/html files.
Comment 12 Petr Pisl 2011-11-11 10:56:17 UTC
I forgot to increase the priority.
Comment 13 Petr Pisl 2011-11-12 11:03:49 UTC
*** Bug 204964 has been marked as a duplicate of this bug. ***
Comment 14 Petr Pisl 2011-11-16 13:54:21 UTC
Final fix is now in web-main.
http://hg.netbeans.org/web-main/rev/9e3a20265dee
Comment 15 Quality Engineering 2011-11-17 07:27:43 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/9e3a20265dee
User: Petr Pisl <ppisl@netbeans.org>
Log: #204686 - Updated IDE on 4th Nov 2011 and now the 'comment'/'uncomment' buttons no longer add/remove comments from my php/html files.
Comment 16 Vladimir Riha 2011-12-01 17:15:59 UTC
verified

Product Version: NetBeans IDE 7.1 RC2 (Build 201111302200)
Java: 1.7.0_02; Java HotSpot(TM) Client VM 22.0-b10
System: Linux version 3.0.0-13-generic-pae running on i386; UTF-8; en_US (nb)