Fixed by configuring the "netbeans.installation" in the profiler RunCheckerImpl.

http://hg.netbeans.org/profiler-main/rev/16b8e64abb2f

Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/16b8e64abb2f
User: Jaroslav Bachorik <yardus@netbeans.org>
Log: #203199: A change in Maven project support for NBM modules and platform applications caused the profiling functionality to break for those project types. Fixed by explicitly configuring the maven goal with "netbeans.installation" property in the profiler RunCheckerImpl.

This fix looks suspicious to me. I am not sure what your evaluation consisted of. Do you claim that bug #199922 was not in fact fixed, or that the fix regressed between 7.0 and now?

First of all, guessNetbeansInstallation should not exist. ${netbeans.installation} must be defined in your ~/.m2/settings.xml in order to run module suites, much less profile them.

Second, netbeans.installation is used only for module suites and standalone modules, both of which are *deprecated* for Maven since they use an IDE installation on disk (nbm:run-ide goal). The primary use case is running a self-contained application (using nbm:run-platform), which gets everything from the repository and does not need this property. You look to be defining the property for both goals, which is certainly wrong.

I would recommend 16b8e64abb2f be backed out and a more precise description of the current problem, and its relation to prior fixes, be written down.

BTW also please avoid reformatting sections of code you are not semantically modifying.

I have no idea whether bug #199922 was fixed or not. I do suppose it had been as it was verified by the reporter.

I don't know anything about deprecation of the NetBeans Module maven project type - the new project wizard allows me to create this project type without any warnings. You still can invoke Run and Debug actions and they are using nbm:run-ide goal under the hood. 

I am backing out the changeset as requested. After the backout the situation is following:
1. Profiling NetBeans Application projects works
2. Profiling NetBeans Module projects doesn't work - still the same error message "The parameters 'netbeansInstallation'
for goal org.codehaus.mojo:nbm-maven-plugin:3.6:run-ide are missing or invalid" appears
3. Profiling NetBeans Module Suite projects doesn't work at all - profiler completely ignores this kind of packaging

My attempt on fixing this issue was copying/pasting the functionality I found in "maven.apisupport" which takes care of actually invoking run and debug actions on a NetBeans Module project. Specifically, the "guessNetbeansInstallation()" method (which should not exist according to your last comment) was copied over from "maven.apisupport/src/org/netbeans/modules/maven/apisupport/NbmActionGoalProvider.java".

Regarding reformatting the code - are you referring to fixing inconsistent 8 space indenting of a private variable where the others are 4 space indented? In this case I prefer fixing it than leaving it be - firstly, the incorrect indenting was plainly a mistake and secondly the noise it brings into the diff is really low being only one such change (I wouldn't do that for en masse of indentation for sure).

I am reassigning the issue to jglick since the fix I provided was the only one that worked for me and I truly have no idea where in maven support to look for additional hints.

Backout changeset:

http://hg.netbeans.org/profiler-main/rev/4eb6e1d31c88

Does this mean Issue #199922 should be also reopened now?

(In reply to comment #5)
> Backout changeset:
> 
> http://hg.netbeans.org/profiler-main/rev/4eb6e1d31c88

OK, I will look at it after this propagates; http://deadlock.netbeans.org/hudson/job/profiler-main/lastCompletedBuild/testReport/ is failing currently.

Thanks. 

The profiler-main build should get fixed once a47670c57454 from jet-main gets to profiler-main.

(In reply to comment #4)
> I don't know anything about deprecation of the NetBeans Module maven project
> type - the new project wizard allows me to create this project type without any
> warnings.

I have added warnings. (The "module" template is fine so long as it is part of an "application". "Suite" is always deprecated.)

> You still can invoke Run and Debug actions and they are using
> nbm:run-ide goal under the hood. 

Right; this is the deprecated mode.

> 1. Profiling NetBeans Application projects works

Which is the important thing, and means that bug #199922 is still fixed.

> 2. Profiling NetBeans Module projects doesn't work - still the same error
> message "The parameters 'netbeansInstallation'
> for goal org.codehaus.mojo:nbm-maven-plugin:3.6:run-ide are missing or invalid"
> appears

Only if you have in fact failed to define this parameter in ~/.m2/settings.xml. It is set automatically when you create a "suite". I have to think about whether there are other places in the UI where it makes sense to set it when it is not yet set.

> 3. Profiling NetBeans Module Suite projects doesn't work at all - profiler
> completely ignores this kind of packaging

Not surprising, since this is a POM project. Possibly needs to be fixed in the archetype rather than the IDE.

> "guessNetbeansInstallation()" method (which should not exist according to your
> last comment) was copied over from
> "maven.apisupport/src/org/netbeans/modules/maven/apisupport/NbmActionGoalProvider.java".

I will look for a way to delete this or rework it.

OK, did some investigation. First of all I dealt with ${netbeans.installation} in a better and more generic way. Anyway this only matters if you do not already have it defined in settings.xml.


Now for the profiler part. To start with, I cannot find the purpose of <profiler.action>...</profiler.action>, in any packaging type. maven.profiler/src/org/netbeans/modules/maven/profiler/ActionMappings.xml seems to be the only file in the source base that even refers to a property of this name. Deleting the several occurrences from ActionMappings.xml seems to have no effect on anything. Perhaps this is left over from some old implementation?


As far as profiling suites goes, the proper approach would be for the archetype to define in nbactions.xml:

    <action>
        <actionName>profile</actionName>
        <goals>
            <goal>package</goal>
            <goal>nbm:cluster</goal>
            <goal>nbm:run-ide</goal>
        </goals>
        <properties>
            <netbeans.run.params.ide>${profiler.args.prefixed} ${profiler.jdkhome.opt}</netbeans.run.params.ide>
        </properties>
    </action>

You can test this by just adding that snippet to a suite project's nbactions.xml. This makes the Profile Project button actually do something. But, RunCheckerImpl.checkRunConfig returns early since sessionProperties == null, because configureProject was never called, because MavenProjectProfilingSupportProvider.isProfilingSupported returns false, because supportedPTypes does not include TYPE_POM.

Nor would we really want to include TYPE_POM in there; for most POM projects, profiling would be utterly meaningless - it is only the weird case of a "suite" project that has run-like actions. But this means that supportedPTypes, besides hardcoding specific packaging types, is not really right - it should rather be examining the action mapping for the project to see if it has ACTION_PROFILE (or perhaps one of the related commands).


On the subject of hardcoding packaging types, I think it is wrong that maven.profiler, in the Java SE IDE, is supplying goals for EE, NBM, etc. projects. Probably ProfilerActionsProvider should be deleted, and the contents of .../maven/profiler/ActionMappings.xml moved into the appropriate modules (maven, maven.j2ee, maven.apisupport). Granted these do not have a dependency on the profiler cluster, but that seems to be a lesser layering violation.

Suites could not be profiled in 7.0; this was probably never possible.

Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/e5bdd4c9a2af
User: Jesse Glick <jglick@netbeans.org>
Log: Ensure netbeans.installation is defined whenever needed. Mentioned in bug #203199.

Jesse, thanks for helping out!

Indeed, a proper integration of the profiler actions into the IDE will be the right way to go. Will address it in #203519.

Profiler side changes implemented in http://hg.netbeans.org/profiler-main/rev/cf681524d222

The profiler actions now utilize the StartupExtender infrastructure to provide correct JVM arguments for the started java process. 

If the profiling of suite projects should work at all the following requirements must be fulfilled:
1. Suite project must have a distinct packaging type
2. suite specific packaging must take into account the JVM args generated by StartupExtender infrastructure
OR
1. POM packaging type must take into account the JVM args generated by StartupExtender infrastructure
2. nbactions.xml in the suite archetype must include the following "profile" action mapping

  <action>
      <actionName>profile</actionName>
      <goals>
          <goal>package</goal>
          <goal>nbm:cluster</goal>
          <goal>nbm:run-ide</goal>
      </goals>
      <properties>
          <netbeans.run.params.ide/>
      </properties>
  </action>

in http://hg.netbeans.org/core-main/rev/fad8c401388e i've removed the suite wizard from the UI, it's been long marked as not suites for production environments