This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 202525 - few whitelist issues in EE project types
Summary: few whitelist issues in EE project types
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Code (show other bugs)
Version: 7.1
Hardware: All All
: P1 normal (vote)
Assignee: David Konecny
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-23 03:39 UTC by David Konecny
Modified: 2011-09-27 12:41 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Stack trace from Verify action. (1.38 KB, text/plain)
2011-09-23 12:10 UTC, Jiri Skrivanek 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Konecny 2011-09-23 03:39:37 UTC 
Few issues have made it into 7.1Beta branch which I would like to fix if possible:

* WhiteList panel in project properties has a label at the bottom which causes more confusion then help and should be removed

* WhiteList panel is not shown in project properties of EAR project and also is not shown in any of Maven based projects

* prevent deadlock in WhiteListLookup. It is too eager and is using AuxProperties before project's lookup was created. It should initialize itself once it is needed

* Verify action (which delegates its invocation to project's application server) is missing on Maven project type
Comment 1 David Konecny 2011-09-23 03:41:38 UTC 
Jirka, Petr, do you think we could integrate this into 71Beta branch? I just pushed the fix: http://hg.netbeans.org/web-main/rev/4c6fafd968b7

In any case could you test it Jirka? I will send you instructions offline.
Comment 2 Petr Jiricka 2011-09-23 08:20:40 UTC 
Cc'ing Marian - Marian, do you agree with merging this to beta branch?
Comment 3 Marian Mirilovic 2011-09-23 09:11:32 UTC 
Yes, go ahead and integrate.
Comment 4 Jiri Skrivanek 2011-09-23 12:10:00 UTC 
Created attachment 111094 [details]
Stack trace from Verify action.

Verify action on maven web project throws an exception and White List Tool console is empty (see stack trace). Otherwise it is OK.

Product Version: NetBeans IDE Dev (Build web-main-5894-on-20110923)
Java: 1.7.0; Java HotSpot(TM) Client VM 21.0-b17
System: Windows XP version 5.1 running on x86; Cp1250; en_US (nb)
Comment 5 David Konecny 2011-09-24 06:36:08 UTC 
(In reply to comment #4)
> Verify action on maven web project throws an exception

I've seen this once myself but could not reproduce it. On the other hand it is most likely caused by the fact that when Maven execution is finished and listeners are notified via taskFinished() then "jmp.verify(fo, null)" should not be called in the same thread but posted somewhere else which I'm fixing in 40eec1026b89. This additional fix is safe and limited only to Verify action in context of Maven projects so I'm going to push it to 71beta branch as well now. Thanks Jirka for testing.
Comment 6 David Konecny 2011-09-24 08:14:16 UTC 
Integrated into release71_beta:
ff9023ad9ba9
f7e2c5f5c1db
Comment 7 Quality Engineering 2011-09-25 14:05:29 UTC 
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/40eec1026b89
User: David Konecny <dkonecny@netbeans.org>
Log: #202525 - few whitelist issues in EE project types
prevent IllegalThreadStateException by posting server verify action into RP
Comment 8 Jiri Skrivanek 2011-09-27 12:41:45 UTC 
Verified in NetBeans IDE 7.1 Beta (Build 201109252201).