This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
To allow template wizards to have the single entry point in JDev and NetBeans, I have implemented TemplateWizardFactory, which finds appropriate implementation of TemplateWizardProvider depending on the IDE.
Created attachment 111055 [details] Diff file
Created attachment 111081 [details] Second part of the diff
TZ01: The first diff does not contain any API change. TZ02: The API in the second diff logically does not belong to Java Queries API. TZ03: No Javadoc, No api changes, TZ04: Inc spec version TZ05: TemplateWizardFactory has public constructor TZ06: The provider = Lookup.getDefault().lookup(TemplateWizardProvider.class) in static initializer may cause problems to FoD. TZ07: TemplateWizardFactory.create and TemplateWizardFactory.createForSuper uses raw types the same holds for TemplateWizardProvider.
TZ01: fixed TZ02: We don't have any other suitable module TZ03: fixed TZ04: fixed TZ05: fixed TZ06: fixed TZ07: fixed I plan to integrate the changes tomorrow before the public holiday.
Created attachment 111183 [details] fixed diff
(Not really necessary to file an API review for a friend API like this, but fine if you are soliciting comments, and anyway good practice for public APIs.) [JG01] Delete 'static TemplateWizardProvider provider' and just look up the instance whenever needed. [JG02] TemplateWizardProvider has no class Javadoc, and very minimal method Javadoc. [JG03] Javadoc tip: {@link WizardDescriptor.InstantiatingIterator} is just noisy when Javadoc will anyway be showing a link to the method's return type. [JG04] Mercurial tip: be sure to use 'hg mv' (including Move refactoring in the IDE), not copy & delete. In this case --- a/form.nb/src/org/netbeans/modules/nbform/wizard/TemplateWizardIterator.java +++ /dev/null @@ -1,343 +0,0 @@ ...... --- /dev/null +++ b/java.source.queriesimpl/src/org/netbeans/modules/java/source/queriesimpl/TemplateWizardIterator.java @@ -0,0 +1,345 @@ .... gives no indication of what lines you actually changed when moving this class, beyond the obvious change of package declaration. I will attach a patch which fixes that, and which shows the addition of two apparently unused imports.
Created attachment 111205 [details] Diff showing rename hg imp --no-commit /tmp/update.diff hg addrem -s 90 form.nb java.source.queriesimpl hg di > /tmp/update2.diff
Created attachment 111242 [details] diff [JG01 - JG04] fixed
b55d75aa00f9
JG02 and JG03 were not in fact addressed, but they were trivial anyway. By the way when mentioning a changeset it is good to give also the team repo you committed to, in case it has not yet propagated, e.g.: jet-main #b55d75aa00f9 http://wiki.netbeans.org/BrowserTools#Link_to_Mercurial_Changesets can be used to hyperlink these.
Caused nbbuild test failure fixed in core-main#6175d93b4e71