Bug 201697 - Replace servletapi with javax.servlet
Replace servletapi with javax.servlet
Status: NEW
Product: ide
Classification: Unclassified
Component: libs
7.1
All All
: P3 (vote)
: TBD
Assigned To: Tomas Stupka
issues@ide
issue_reviewed
: ARCH
Depends on:
Blocks: 198248
  Show dependency treegraph
 
Reported: 2011-09-06 18:13 UTC by Jesse Glick
Modified: 2013-07-11 08:17 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2011-09-06 18:13:57 UTC
Now that we include javax.servlet (2.5) as a bundle, probably servletapi (2.2) could be removed, with the usual module auto dep replacement.

Need to also check for j2se-type libraries referencing the old location.
Comment 1 Jesse Glick 2011-09-06 18:16:05 UTC
Also consider javax.xml.rpc (and .soap) vs. websvc.jaxrpc16.
Comment 2 Jesse Glick 2011-09-06 18:17:32 UTC
And contrib/libs.commons_lang vs. o.apache.commons.lang.
Comment 3 Jesse Glick 2011-09-06 18:18:30 UTC
And o.eclipse.osgi vs. netbinox. Just look over nbbuild/build/generated/shared-packages.txt generally.
Comment 4 Tomas Stupka 2011-09-07 14:16:49 UTC
(In reply to comment #3)
> And o.eclipse.osgi vs. netbinox.
core-main #2851b19314e0
Comment 5 Quality Engineering 2011-09-07 14:31:41 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/d6f24acac4d6
User: Jesse Glick <jglick@netbeans.org>
Log: Use o.apache.commons.io from extexecution.destroy; cf. #201697.
Comment 6 Jesse Glick 2011-09-07 19:46:00 UTC
(In reply to comment #4)
>> And o.eclipse.osgi vs. netbinox.
> core-main #2851b19314e0

I wonder - should org.eclipse.osgi rather be retained, and netbinox made to depend on it? Since it seems that several bundles want to depend on it. It is not clear to me if those bundles would work if, say, Felix were running as the container and org.eclipse.osgi were simply made available as a regular bundle to import.
Comment 7 Jaroslav Tulach 2011-09-08 07:13:10 UTC
(In reply to comment #6)
> (In reply to comment #4)
> >> And o.eclipse.osgi vs. netbinox.
> > core-main #2851b19314e0
> 
> I wonder - should org.eclipse.osgi rather be retained, and netbinox made to
> depend on it?

That would different solution than the one we use for Felix. But it is true, nobody depends on Felix, as Felix provides no APIs except those in OSGi spec.

> Since it seems that several bundles want to depend on it. It is
> not clear to me if those bundles would work if, say, Felix 

This is what we tried a year ago. Eclipse bundles cannot run on top of Felix.

> org.eclipse.osgi were simply made available as a regular bundle
> to import.

That does not work. Many classes are then loaded twice by different classloaders. OSGi is not ready for running one container in another at all.
Comment 8 Jesse Glick 2011-09-08 12:41:23 UTC
And check html.validation vs. o.apache.commons.logging (the bundle actually is of an older release).
Comment 9 Jesse Glick 2011-09-08 12:43:27 UTC
(In reply to comment #8)
> check html.validation vs. o.apache.commons.logging

Noticed due to:

WARNING [org.netbeans.ProxyClassLoader]: Will not load class org.apache.commons.logging.impl.Jdk14Logger arbitrarily from one of ModuleCL@61736e[org.netbeans.modules.html.validation] and Netigso[reference:file:.../ide/modules/org-apache-commons-logging.jar] starting from SystemClassLoader[511 modules]; see http://wiki.netbeans.org/DevFaqModuleCCE
Comment 10 Quality Engineering 2011-09-08 14:31:22 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/2851b19314e0
User: Tomas Stupka <tstupka@netbeans.org>
Log: issue #201697 - Replace servletapi with javax.servlet
remove o.eclipse.osgi, the library is already present in netbinox
Comment 11 Marian Mirilovic 2013-07-11 08:17:38 UTC
Tomas,
what is the status of this issue, please ? Thanks in advance.


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo