This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 200783 - Endless loop in command completion when quoteString = "" (Bugs: #179413, #167564)
Summary: Endless loop in command completion when quoteString = "" (Bugs: #179413, #167...
Status: RESOLVED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Code (show other bugs)
Version: 7.0.1
Hardware: PC Other
: P3 normal (vote)
Assignee: Jiri Rechtacek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-09 11:05 UTC by matthias42
Modified: 2011-10-20 14:29 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Fix endless loop in unquote and correct already quoted (2.09 KB, patch)
2011-08-09 11:05 UTC, matthias42 		Details | Diff
Revised patch (in the completion the case queryString.length() == 0 has to be special cased) (3.42 KB, patch)
2011-08-15 19:16 UTC, matthias42 		Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description matthias42 2011-08-09 11:05:47 UTC 
Created attachment 109882 [details]
Fix endless loop in unquote and correct already quoted

Hey,

after the fix in #179413 for the emtpy quoteString for Informix Databases I'm faced with a endless loop in command completion. The bug was mentioned in #167564 where it was caused and worked around, but not fixed.

Attached you find a patch, that fixes the endless loop and still suvives the unittests.

Additionally that patch fixes the check "alreadyQuoted", which returned true, if the string just consisted of the quoteString alone (without a matching ending quote).

Greetings

Matthias
Comment 1 matthias42 2011-08-15 19:16:50 UTC 
Created attachment 109992 [details]
Revised patch (in the completion the case queryString.length() == 0 has to be special cased)
Comment 2 matthias42 2011-10-12 19:24:29 UTC 
This is a regression - can this go into 7.1? What holds it back?
Comment 3 Jiri Rechtacek 2011-10-14 15:57:56 UTC 
Thanks for your patch, I'm going review and push in a few days.
Comment 4 Jiri Rechtacek 2011-10-19 11:31:25 UTC 
Thanks a lot for your patch, was applied in core-main/rev/d6df98245ee6, core-main/rev/3a3f7510183c
Comment 5 Quality Engineering 2011-10-20 14:29:35 UTC 
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/3a3f7510183c
User: Jiri Rechtacek <jrechtacek@netbeans.org>
Log: #200783 - Endless loop in command completion when quoteString = "" (Bugs: #179413, #167564);
applied matthias42's patch, thanks