This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 200427 - History tab for editors in Web, EE, ... areas
Summary: History tab for editors in Web, EE, ... areas
Status: RESOLVED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: Editing infrastructure (show other bugs)
Version: 7.1
Hardware: All All
: P1 normal (vote)
Assignee: Petr Jiricka
URL: http://wiki.netbeans.org/EditorHistor...
Keywords:
: 201987 (view as bug list)
Depends on: 201987
Blocks: 198115
  Show dependency tree
 
Reported: 2011-07-27 12:32 UTC by Antonin Nebuzelsky
Modified: 2011-10-26 06:47 UTC (History)
10 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonin Nebuzelsky 2011-07-27 12:32:35 UTC
In 7.1 a new History tab is being introduced to the editors where it makes
sense to allow the users quick access to the local history of changes of the
relevant file.

In the following document you can find:
* the list of identified DataObjects
* the owners
* the section Necessary Steps with how-to

http://wiki.netbeans.org/EditorHistoryTab

See the DataObjects in the areas related to Web, EE, Groovy, ...
Comment 1 Petr Jiricka 2011-07-27 13:45:53 UTC
I'd like to ask the people on cc to take care of the individual subareas below. Please update the wiki page (put x in the Done column) when done. This should be completed by feature freeze, but the sooner it is done, the better. Thanks a lot.

Martin:
coherence/src/org/netbeans/modules/coherence/editor/cache/CacheConfigDataObject.java
coherence/src/org/netbeans/modules/coherence/editor/config/CoherenceConfigDataObject.java
coherence/src/org/netbeans/modules/coherence/editor/pof/PofConfigDataObject.java
spring.beans/src/org/netbeans/modules/spring/beans/loader/SpringXMLConfigDataObject.java
web.jsf/src/org/netbeans/modules/web/jsf/JSFConfigDataObject.java
web.struts/src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java

Sergey:
hibernate/src/org/netbeans/modules/hibernate/loaders/mapping/HibernateMappingDataObject.java
hibernate/src/org/netbeans/modules/hibernate/loaders/reveng/HibernateRevengDataObject.java
hibernate/src/org/netbeans/modules/hibernate/loaders/cfg/HibernateCfgDataObject.java
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/unit/PUDataObject.java

Marek:
html/src/org/netbeans/modules/html/HtmlDataObject.java
web.core/src/org/netbeans/modules/web/core/jsploader/JspDataObject.java	Marek F
web.core/src/org/netbeans/modules/web/core/jsploader/JspServletDataObject.java
web.core/src/org/netbeans/modules/web/taglib/TLDDataObject.java

Petr H:
j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/common/xmlutils/XMLJ2eeDataObject.java
j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/multiview/DDMultiViewDataObject.java
xml.multiview/src/org/netbeans/modules/xml/multiview/XmlMultiViewDataObject.java

Vince:
j2ee.sun.appsrv/src/org/netbeans/modules/j2ee/sun/ide/sunresources/resourcesloader/SunResourceDataObject.java
j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/ddloaders/DDMultiViewDataObject.java

Denis:
websvc.jaxrpc/src/org/netbeans/modules/websvc/wsdl/xmlutils/XMLJ2eeDataObject.java
websvc.design/src/org/netbeans/modules/websvc/design/loader/JaxWsDataObject.java
websvc.rest.wadl.design/src/org/netbeans/modules/websvc/rest/wadl/design/loader/WadlDataObject.java
Comment 2 Denis Anisimov 2011-08-02 17:26:05 UTC
websvc.jaxrpc module is not longer supported. It seems it isn't even on Plugins portal of NB.
websvc.rest.wadl.design is also no longer under development. But it *IS* on Plugins portal of NB.

So do I really have to care about the issue for DataObjects from these modules ?
Comment 3 Petr Jiricka 2011-08-03 07:30:54 UTC
Ok, let's ignore websvc.jaxrpc. For websvc.rest.wadl.design, I think it would be useful to look into it briefly and do it if it's easy. If not, ignore it as well.
Comment 4 Petr Hejl 2011-08-03 14:26:59 UTC
I tried to fix XMLMultiViewDataObject, but I haven't been sucessfull. I refactored wiki to track the hierarchy of objects. I'm not sure the XMLMultiViewDataObject itself should be fixed/changed directly. Same applies to XMLJ2eeDataObject hierarchy.
Comment 5 Petr Hejl 2011-08-04 19:59:28 UTC
XmlMultiViewDataObject/ClientDataObject web-main 62d8ccf04a3e
Comment 6 Quality Engineering 2011-08-05 14:37:42 UTC
Integrated into 'main-golden', will be available in build *201108050600* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/62d8ccf04a3e
User: phejl@netbeans.org
Log: #200427 History tab for editors in Web, EE, ... areas
Comment 7 Petr Hejl 2011-08-08 10:26:58 UTC
XMLJ2eeDataObject/EarDataObject web-main 924b6edf4e14
Comment 8 Denis Anisimov 2011-08-09 07:00:41 UTC
JaxWsDataObject web-main#a151087b9297
Comment 9 Denis Anisimov 2011-08-09 08:28:28 UTC
WadlDataObject :web-main#e57a86ee0ed4
Comment 10 Denis Anisimov 2011-08-09 08:36:24 UTC
The notice about modification existed MultiViewComponents:
I've followed by the wiki and changeset for "form" module.
The last thing which it contains is CloseHandler registration for mime-type.
It doesn't work for me.
CloseHandler is instantiated with empty argument CTOR and it has no reference to
DataObject in the result. Probably this is consequence of wrong argument in the 
second CTOR but I've failed with Lookup argument too.
But I've checked current implementation of FormEditorSupport and haven't found
CloseHandler registration at all.
Instead of CloseHandler there is special impl for canCloseElement(TopComponent)
in the source editor multiview element ( which is delegated to editor support ) .
After change impl of this method I've got correctly working close operation .

So please beware of this issue in your modifications.
Comment 11 Quality Engineering 2011-08-10 21:29:24 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/a151087b9297
User: Denis Anisimov <ads@netbeans.org>
Log: Changed JaxWsDataObject : fix for BZ#200427 - History tab for editors in Web, EE, ... areas
Comment 12 Vince Kraemer 2011-08-11 04:35:13 UTC
(In reply to comment #11)
> Integrated into 'main-golden'
> Changeset: http://hg.netbeans.org/main-golden/rev/a151087b9297
> User: Denis Anisimov <ads@netbeans.org>
> Log: Changed JaxWsDataObject : fix for BZ#200427 - History tab for editors in
> Web, EE, ... areas

There may be a problem with main-golden....

I see...

An error occurred while processing your request

00manifest.i@a151087b9297: no match found

when I access the URL
Comment 13 Denis Anisimov 2011-08-11 05:55:13 UTC
(In reply to comment #12)
> (In reply to comment #11)
> > Integrated into 'main-golden'
> > Changeset: http://hg.netbeans.org/main-golden/rev/a151087b9297
> > User: Denis Anisimov <ads@netbeans.org>
> > Log: Changed JaxWsDataObject : fix for BZ#200427 - History tab for editors in
> > Web, EE, ... areas
> 
> There may be a problem with main-golden....
> 
> I see...
> 
> An error occurred while processing your request
> 
> 00manifest.i@a151087b9297: no match found
> 
> when I access the URL

Yes, I think main-golden is the problem.
You can use web-main urls :
http://hg.netbeans.org/web-main/rev/a151087b9297
http://hg.netbeans.org/web-main/rev/e57a86ee0ed4
The second contains also changes for CloseHandler modification of JaxWsDataObject.
Comment 14 Martin Fousek 2011-08-11 09:06:23 UTC
SpringXMLConfigDataObject: web-main #24eddfdbdd2b
StrutsConfigDataObject: web-main #0740a7213340
Comment 15 Petr Hejl 2011-08-11 14:37:40 UTC
EjbJarMultiviewDataObject web-main b66ca0281599
Comment 16 Quality Engineering 2011-08-11 21:00:44 UTC
Integrated into 'main-golden', will be available in build *201108111304* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/75a722417fb8
User: Sergey B. Petrov <sj-nb@netbeans.org>
Log: #200427  versions
Comment 17 Quality Engineering 2011-08-12 14:40:52 UTC
Integrated into 'main-golden', will be available in build *201108120601* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/b66ca0281599
User: phejl@netbeans.org
Log: #200427 History tab for editors in Web, EE, ... areas
Comment 18 Martin Fousek 2011-08-12 15:43:58 UTC
JSFConfigDataObject: web-main #72b259055cab

All Coherence related DOs will be done later once will be finished rewrite to XAM/XDM by Andrew H. Anyway Coherence will be available just as plugin for NetBeans 7.1.
Comment 19 Quality Engineering 2011-08-13 14:14:46 UTC
Integrated into 'main-golden', will be available in build *201108130601* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/72b259055cab
User: Martin Fousek <marfous@netbeans.org>
Log: #200427 - History tab for editors in Web, EE, ... areas - JSFConfigDataObject
Comment 20 Petr Hejl 2011-08-15 14:04:57 UTC
uff DDDataObject/DDFragmentDataObject web-main 63d03025e253
Comment 21 Kenneth Ganfield 2011-08-16 12:45:16 UTC
If possible, the History tab should have an F1 help id to open a context-sensitive help topic
Comment 22 Quality Engineering 2011-08-16 13:53:17 UTC
Integrated into 'main-golden', will be available in build *201108160601* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/63d03025e253
User: phejl@netbeans.org
Log: #200427 History tab for editors in Web, EE, ... areas
Comment 23 Vince Kraemer 2011-08-16 15:15:52 UTC
it looks like the quality auto commenter missed this... http://hg.netbeans.org/main-golden/rev/4e926f78b756
Comment 24 Sergey Petrov 2011-08-19 10:17:12 UTC
I'm not sure if it's related to latest changes yet, but currently both application-client.xml and persistence.xml have text/xml mimetype at source tab instead of mimetypes returned by getEditorMimeType() at least at time completion providers are initialized. It cause some problems with completion.
Comment 25 Sergey Petrov 2011-08-19 12:45:42 UTC
Just found last one isnt' related to multiview changes/this enhancment implementation and is old issue 127051
Comment 26 Quality Engineering 2011-08-19 14:41:13 UTC
Integrated into 'main-golden', will be available in build *201108190601* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/6ec550dbaad8
User: Martin Fousek <marfous@netbeans.org>
Log: #200427 - History tab for editors in Web, EE, ... areas - fixed JSFConfigDataObject close
Comment 27 Sergey Petrov 2011-08-19 16:47:47 UTC
persistence/hibernate done, see wiki for main changesets
Comment 28 Quality Engineering 2011-08-20 14:12:16 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/3483d1b04fd3
User: Sergey B. Petrov <sj-nb@netbeans.org>
Log: #200427 change caption
Comment 29 Marek Fukala 2011-09-20 17:24:53 UTC
following DataObjects and CSL languages fixed in web-main#e693d8f8331a:

CssLanguage
JsLanguage (javascript)
HtmlDataObject
JspDataObject
TldDataObject
Comment 30 Petr Jiricka 2011-09-20 20:56:33 UTC
*** Bug 201987 has been marked as a duplicate of this bug. ***
Comment 31 Quality Engineering 2011-09-21 07:59:17 UTC
Integrated into 'main-golden', will be available in build *201109202329* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/e693d8f8331a
User: Marek Fukala <mfukala@netbeans.org>
Log: #200427 - History tab for editors in Web, EE, ... areas
Comment 32 Vladimir Riha 2011-09-22 06:43:05 UTC
Using NetBeans IDE Dev (Build 201109202329), there is still no history tab for javascript (but html, css, php & jsp works)
Comment 33 Marek Fukala 2011-09-22 07:09:13 UTC
(In reply to comment #32)
> Using NetBeans IDE Dev (Build 201109202329), there is still no history tab for
> javascript (but html, css, php & jsp works)

Isn't it just because of old serialized javascript TopComponent? If you create and open a new javascript file is it still not working?
Comment 34 Vladimir Riha 2011-09-22 07:17:49 UTC
Unfortunately not, I did creat new file and it's not working.
Comment 35 Tomas Stupka 2011-09-22 09:06:47 UTC
o.n.m.javascript.editing.JsLanguage.java is missing useMultiview=true in @LanguageRegistration(mimeType="text/javascript")
Comment 36 Marek Fukala 2011-09-22 10:27:56 UTC
From whatever reason I was under impression it worked for me as for the css files.

useMultiview=true added in web-main#653dfb2601c4
Comment 37 Quality Engineering 2011-09-23 13:19:53 UTC
Integrated into 'main-golden', will be available in build *201109230601* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/653dfb2601c4
User: Marek Fukala <mfukala@netbeans.org>
Log: #200427 - History tab for editors in Web, EE, ... areas
Comment 38 Tomas Stupka 2011-10-24 13:42:57 UTC
hi, 

is this issue fixed?
Comment 39 Martin Fousek 2011-10-24 15:52:32 UTC
From my files there are still missing Coherence files but I'm still not sure if it's good time for doing that. Anyway, Coherence is not part of build for this release for sure. I will speak about it more with PetrJ.
Comment 40 Martin Fousek 2011-10-26 06:47:53 UTC
We decided with PetrJ to enter new issue for Coherence DDs since it's not important for NB71 and it requires timing with main Coherence's contributor - author: bug #204249

Coherence will not be part of standard distribution for NB7.1 release and the rest of DataObjects seemed to us completed, so I was asked to close this one as fixed.