This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 199572 - Attach wizard does incorrect modifications to catalina.sh
Summary: Attach wizard does incorrect modifications to catalina.sh
Status: VERIFIED FIXED
Alias: None
Product: profiler
Classification: Unclassified
Component: Attach (show other bugs)
Version: 7.0
Hardware: PC Linux
: P1 normal (vote)
Assignee: J Bachorik
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2011-06-21 08:18 UTC by J Bachorik
Modified: 2011-07-06 00:02 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description J Bachorik 2011-06-21 08:18:08 UTC 
Since introduction of the usage of LinuxPosixThreadsCPUClocks the attach wizard fails to correctly modify Tomcat's catalina.sh file.
The resulting CATALINA_OPTS definitions is:
CATALINA_OPTS= -XX:+UseLinuxPosixThreadCPUClocks -agentpath:/opt/netbeans/profiler/lib/deployed/jdk16/linux-amd64/libprofilerinterface.so=/opt/netbeans/profiler/lib,5140

where it should be:
CATALINA_OPTS=" -XX:+UseLinuxPosixThreadCPUClocks -agentpath:/opt/netbeans/profiler/lib/deployed/jdk16/linux-amd64/libprofilerinterface.so=/opt/netbeans/profiler/lib,5140"

The contained space causes the shell go crazy and basically ignore the profiler modifications.
Comment 1 J Bachorik 2011-06-22 08:32:16 UTC 
Regression introduced by http://hg.netbeans.org/main/rev/5422427852ea
Comment 2 J Bachorik 2011-06-22 08:33:56 UTC 
Fix delivered in http://hg.netbeans.org/main/rev/a51b72797955
Comment 3 J Bachorik 2011-06-22 08:57:30 UTC 
Making this a stopper - the regression was introduced in 7.0
Comment 4 Tomas Hurka 2011-06-22 13:48:59 UTC 
Reviewed. It can be transplanted to release701.
Comment 5 Quality Engineering 2011-06-24 14:29:02 UTC 
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/a51b72797955
User: Jaroslav Bachorik <yardus@netbeans.org>
Log: #199572: Fixing incorrect modification of catalina.sh by the profiler attach wizard introduced by changeset 5422427852ea
Comment 6 Petr Cyhelsky 2011-06-27 08:49:08 UTC 
Verified on:

Product Version: NetBeans IDE Dev (Build 201106260600)
Java: 1.7.0-ea; Java HotSpot(TM) 64-Bit Server VM 21.0-b15
Comment 7 Marian Mirilovic 2011-06-30 07:27:14 UTC 
Went through logs from hg and haven't found this fix in releases clone yet.
Comment 8 J Bachorik 2011-06-30 12:15:44 UTC 
Transplanted into release701_dev branch:
http://hg.netbeans.org/releases/rev/2efdae68b57d
Comment 9 J Bachorik 2011-06-30 13:31:33 UTC 
Transplanted to the correct branch "release701"
http://hg.netbeans.org/releases/rev/5dbcf7d8e808
Comment 10 Quality Engineering 2011-07-06 00:02:06 UTC 
Integrated into 'releases'
Changeset: http://hg.netbeans.org/releases/rev/5dbcf7d8e808
User: Jaroslav Bachorik <yardus@netbeans.org>
Log: #199572: Fixing incorrect modification of catalina.sh by the profiler attach wizard introduced by changeset 5422427852ea
(transplanted from a51b72797955a9c6dc76a6925993b583f7852b65)