This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 195845 - Add JUnit panel to IDE installer
Summary: Add JUnit panel to IDE installer
Status: RESOLVED FIXED
Alias: None
Product: installer
Classification: Unclassified
Component: Code (show other bugs)
Version: 7.0
Hardware: All All
: P1 normal (vote)
Assignee: Yulia Novozhilova
URL:
Keywords:
Depends on:
Blocks: 195846 195849
  Show dependency tree
 
Reported: 2011-02-23 11:13 UTC by Jiri Rechtacek
Modified: 2011-03-01 17:48 UTC (History)
0 users

See Also:
Issue Type: TASK
Exception Reporter:

Attachments
ui spec (2.15 MB, application/octet-stream)
2011-02-23 11:16 UTC, Jiri Rechtacek 		Details
junit_license_panel.patch (30.80 KB, application/octet-stream)
2011-02-26 15:55 UTC, Yulia Novozhilova 		Details
a junit_denied patch (3.31 KB, patch)
2011-02-28 09:56 UTC, Jiri Rechtacek 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Rechtacek 2011-02-23 11:13:46 UTC 
The installer will it will include a new panel with the JUnit license and with the two radio buttons (but the Next button will be enabled for both options), and the Summary installer panel will include the note about JUnit installation later in the IDE
Comment 1 Jiri Rechtacek 2011-02-23 11:16:29 UTC 
Created attachment 106326 [details]
ui spec
Comment 2 Jiri Rechtacek 2011-02-24 11:31:26 UTC 
Implementation of issue 195846 assumed content of $installdir/nb/var/license_accepted contains:
* junit_accepted - if user saw JUnit panel and choose JUnit installation
* junit_denied - if user saw JUnit panel and choose Do not install JUnit
If user doesn't see JUnit panel (e.g. PHP-only distributio), the installer writes nothing in that file.
Comment 3 Yulia Novozhilova 2011-02-26 15:54:14 UTC 
Jirka, the installer part is ready (patch is attached). I will integrate it as soon as you give me a signal.
BTW, I ended up with a more simple solution when JUnit license panel is shown only if javase cluster is going to be installed (i.e. if javase is already installed the panel will not be shown) and license_accepted file is finally changed by javase's ConfigurationLogic class. This approach is not the best but I think it works for 7.0. So now it is not a problem to write "junit_denied" into license_accepted file. Let me know if you want me to implement this or we can proceed with "junit_n_a" solution.
Thanks!
Comment 4 Yulia Novozhilova 2011-02-26 15:55:07 UTC 
Created attachment 106478 [details]
junit_license_panel.patch
Comment 5 Jiri Rechtacek 2011-02-28 09:55:56 UTC 
Hi Yulia, the patch will work by design. If it's not a problem, please add junit_denied option. Both sides should work together immediately. I attached a patch of ConfigurationLogic.java and Bundle.properties to handle junit_denied option. If it makes sense, integrate it into product. Thank you
Comment 6 Jiri Rechtacek 2011-02-28 09:56:47 UTC 
Created attachment 106532 [details]
a junit_denied patch
Comment 7 Yulia Novozhilova 2011-02-28 11:13:58 UTC 
Jirka, please point me to the license file that should be used for junit license panel. I will integrate all the changes as soon as I have it. Thank you.
Comment 8 Yulia Novozhilova 2011-02-28 13:29:52 UTC 
Fixed: http://hg.netbeans.org/core-main/rev/329ba898a037
Comment 9 Quality Engineering 2011-03-01 17:48:28 UTC 
Integrated into 'main-golden', will be available in build *201103011142* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/329ba898a037
User: Yulia Novozhilova <ynov@netbeans.org>
Log: Fix #195845 -  Add JUnit panel to IDE installer