This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 19570 - I18N - The characters of the error message are overlaped.
Summary: I18N - The characters of the error message are overlaped.
Status: CLOSED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Terminalemulator (show other bugs)
Version: 3.x
Hardware: Sun Solaris
: P2 blocker (vote)
Assignee: ivan
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2002-01-18 12:52 UTC by hiroshiy
Modified: 2008-12-23 08:15 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Created an attachment. (6.89 KB, image/gif)
2002-01-18 13:06 UTC, hiroshiy
Details
Patch for the orion_fcs branch (120.35 KB, patch)
2002-04-09 02:17 UTC, Torbjorn Norbye
Details | Diff
Freshly compiled term java files to try it out with orion_fcs build (114.49 KB, application/octet-stream)
2002-04-09 02:19 UTC, Torbjorn Norbye
Details

Note You need to log in before you can comment on or make changes to this bug.
Description hiroshiy 2002-01-18 12:52:40 UTC
To reproduce: 

1. Open the JSP File(e.g. cdshopcart/productList.jsp).
   Syntax Error is made into the JSP File,
   (e.g. "/WEB-INF/lib/ietags.jar"
      -> "/WEB-INF/lib/ietagsaa.jar"), 
   and save.

2. "Compile"
    Error messages are appeared ...

3. Doucle Click the messsage in Output Window, 
   The characters of the error message are overlaped each other.
Comment 1 _ rkubacki 2002-01-18 13:00:44 UTC
Looks like web module problem
Comment 2 hiroshiy 2002-01-18 13:06:56 UTC
Created attachment 4273 [details]
Created an attachment.
Comment 3 hiroshiy 2002-01-21 01:10:43 UTC
To add "I18N -" in summary field.
Comment 4 _ rkubacki 2002-01-25 13:37:25 UTC
reassigned to core (terminal emulator problem?)
Comment 5 akemr 2002-02-08 15:38:01 UTC
Other notes:

- you should use FFJ, not NB
- in JSP make error e.g. in <%@ taglib uri="something.bad" prefix="eg"%>
- error text will display correctly in OW, but if you SELECT part of
text, if gets to be overlaped

Comment 6 akemr 2002-02-08 16:10:06 UTC
Probably somewhere in Term

Note: I used JDK 1.4, Orion dev build
Comment 7 ivan 2002-02-08 21:51:08 UTC
This is similar to the "cursor moves left" issue (don't remember
the number).
Term requires fixed width fonts. What I see in the attached picture
is that the oriental characters are wider than the latin ones.
So you're at column 0 and put out 5 oriental characters.
Now you're at column 5 and put out 5 latin charaters.
Now you're at column 10.
If the oriental characters are, say twice as wide as the latinones,
then they will take screen space fromn column 0 thru 10 and overlap
with the latinn ones from columns 5-10.

The only fix I can think of is to not trust the "max" width of
a font, figure it for myself, and then render each character
independently as opposed to using drawString(), but this can become
very expensive.

Hmmmm
Comment 8 Ken Frank 2002-02-20 17:35:25 UTC
raising priority since this affects user experience
of those using localized FFJ release who could
not be able to fully read the error messages
from Tomcat.
Comment 9 ivan 2002-02-20 21:24:24 UTC
It's a whole lot more complex than the "cursor moves left" issue.
Japanese (and other charset) characters might occupy double-width
cells. DtTerm can handle that. Term cannot at all.
Comment 10 _ ttran 2002-02-28 11:56:09 UTC
Mila Metelka solved this exact problem long time ago in the editor
module.  He can give some insights or give reference to the piece of
code in the editor.

Yes, it's going to be expensive.  But you can't be cheap and
incorrect, unfortunately
Comment 11 Miloslav Metelka 2002-02-28 15:28:31 UTC
Yes we had the same optimization and the same problem with Japanese.
Now we use the FontMetrics for all the text measurements in the editor.
Comment 12 ivan 2002-04-05 20:54:24 UTC
Fixed in 3.4 trunk tag ivan_13
See .../terminalemulator/ReleaseNotes.ivan.txt for gory details.
Comment 13 Torbjorn Norbye 2002-04-09 02:12:37 UTC
The root problem here was that Term did not handle "wide" characters
correctly. This means that in for example the Japanese locale,
if the output contains Japanese characters they display does
not work.

We need this fixed in Orion. I'm attaching a patch for the orion_fcs
branch. There are a lot of diffs, because making Term handle
these fonts correctly involved a lot of work. The fix was done by
Ivan; I've only done the merging to the orion_fcs branch work.
I've also included the patch for 21730 since that's requested into
Orion as well, and it was more work removing it than just leaving
it in.  I'll also attach a .jar file containing the new term
classes if you want to try them out yourself.
Comment 14 Torbjorn Norbye 2002-04-09 02:17:41 UTC
Created attachment 5328 [details]
Patch for the orion_fcs branch
Comment 15 Torbjorn Norbye 2002-04-09 02:19:27 UTC
Created attachment 5329 [details]
Freshly compiled term java files to try it out with orion_fcs build
Comment 16 hiroshiy 2002-04-09 04:53:32 UTC
Hello Tor and Ivan,

I have just started confirmation for your patch file, right now.
The outlines are follows ... 

In my Solaris environment, the first feel is good. 
I tried to indicate some messages, "Overlap" was not occurred yet.
   - Solaris 8 on Sparc (Japanese)
   - JDK 1.4.0 (build 1.4.0-b92)
   - FFJ EE v4.0 (Build 020407)
I will continue the verification of the patch file. 

But, in my Windows environment, your patch file hasn't worked yet. 
   - Windows 2000 SP2 (Japanese)
   - JDK 1.4.0 (build 1.4.0-b92)
   - FFJ EE v4.0 (Build 020407)
I will confirm my windows environment again. 

Thank you - Hiroshi.
Comment 17 hiroshiy 2002-04-09 05:37:30 UTC
In my Windows environment, patch file starts to work. 
I will continue the verification on Solaris and Windows. 

Thank you - Hiroshi.
Comment 18 Jan Chalupa 2002-04-10 10:50:51 UTC
Patch verified. Should be applied to orion_fcs.
Comment 19 hiroshiy 2002-04-12 10:28:26 UTC
I've verified the fixing in "FFJ, EE 4.0 EA (Build 020411)"
Thank you very much !! - Hiroshi
Comment 20 Jesse Glick 2002-12-23 16:35:38 UTC
Consistent use of the I18N keyword.
Comment 21 Quality Engineering 2003-07-01 16:19:16 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.
Comment 22 Quality Engineering 2008-12-23 08:15:26 UTC
moving terminal emulator issues to terminalemulator component.
To see the correct version and target milestone of this issue look at Issue
Activity table.