This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 195059 - build-test-dist produces incomplete bundle
Summary: build-test-dist produces incomplete bundle
Status: VERIFIED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 7.0
Hardware: All All
: P1 normal (vote)
Assignee: Jesse Glick
URL:
Keywords: REGRESSION, TEST
Depends on:
Blocks:
 
Reported: 2011-02-04 08:56 UTC by Vladimir Voskresensky
Modified: 2011-02-07 17:05 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Voskresensky 2011-02-04 08:56:27 UTC
- we are building testdist.zip (using build-test-dist) and then send it to test machines
- looks like bundle recently become incomplete, because when tests are run => error occur [1]

Please, fix it asap, we can not get results from all platforms to verify quality for Beta2

(I can send privately link to our internal test machines)

Thanks,
Vladimir.
[1] tail of log:

do-test:

fail-test:

run-test:

test:

init:
   [delete] Deleting directory /export/home/tester/hudson/workspace/cnd-test-ubuntu.x86_64/unit/classes
    [unjar] Expanding: /export/home/tester/hudson/workspace/cnd-test-ubuntu.x86_64/unit/ide/org-netbeans-modules-terminal/tests.jar into /export/home/tester/hudson/workspace/cnd-test-ubuntu.x86_64/unit/classes
[validatepath] File /export/home/tester/hudson/workspace/cnd-test-ubuntu.x86_64/netbeans/extra/modules/org-netbeans-libs-junit4.jar does not exist.

init-data:

init-platform-properties:

do-test:

fail-test:

run-test:

test:

generate-html-results:
[junitreport] Processing /export/home/tester/hudson/workspace/cnd-test-ubuntu.x86_64/unit/results/TESTS-TestSuites.xml to /tmp/null1256677785
[junitreport] Loading stylesheet jar:file:/usr/share/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 1656ms
[junitreport] Deleting: /tmp/null1256677785
     [echo] Report is available at /export/home/tester/hudson/workspace/cnd-test-ubuntu.x86_64/unit/results/html/index.html

failtests:

all:

BUILD SUCCESSFUL
Total time: 8 seconds
Terminating xvnc.
$ vncserver -kill :23
Killing Xvnc4 process ID 9446
Archiving artifacts
ERROR: No artifacts found that match the file pattern "unit/work/**". Configuration error?
ERROR: 'unit/work/**' doesn't match anything, but '**' does. Perhaps that's what you mean?
Recording test results
Recording fingerprints
Email was triggered for: Failure
There are 1 triggered emails.
Sending email for trigger: Failure
Comment 1 Alexander Pepin 2011-02-04 10:29:05 UTC
No junit jar in platform any more, all QA tests failed.
Comment 2 Leonid Lenyashin 2011-02-04 10:43:27 UTC
Guys, do you read P-Team minutes?
Comment 3 Alexander Pepin 2011-02-04 10:57:40 UTC
I do not receive notifications from NB p-team any more and missed the last line in your letter :(
But it does not change anything, tests are broken and we can not continue automatic testing. Why junit was removed??? For what??? We need it before running the ide!!!
Comment 4 Jesse Glick 2011-02-04 16:27:58 UTC
Something to do with changes relating to libs.junit4; I am trying to see what is wrong.
Comment 5 Jesse Glick 2011-02-04 16:59:21 UTC
I think I see now. It works if ${netbeans.dest.dir} contains the extra cluster with libs.junit4, otherwise not.
Comment 6 Jesse Glick 2011-02-04 17:31:23 UTC
core-main #117f3404a6da should fix it I think. junit-4.8.2.jar was already being copied into testdist, but not being referred to properly from test.properties for a module, which was assuming the IDE contained libs.junit4 in the extra cluster.
Comment 7 Jesse Glick 2011-02-04 17:38:34 UTC
core-main #73371c73026e also needed.
Comment 8 Jesse Glick 2011-02-04 17:41:51 UTC
Also trying a bit of cleanup in core-main #cb82096a87a5.
Comment 9 Jesse Glick 2011-02-04 17:54:09 UTC
...and a rollback of that cleanup: core-main #f7caa2081252
Comment 10 Tomas Danek 2011-02-07 11:00:00 UTC
fix seems to be in production build, and on hudson4qe farm it's working (ide distribution had no extra cluster). Verified.
Comment 11 Alexander Pepin 2011-02-07 14:50:02 UTC
Have the changes been propagated to builds on smetiste (build 2011-02-07) as I still see test failures with message:
...
/export/home/cnd-install/netbeans-7.0/harness/common.xml:1013: The following error occurred while executing this line:
/export/home/cnd-install/netbeans-7.0/harness/common.xml:1006: No dependent module org.netbeans.libs.junit4
BUILD FAILED (total time: 0 seconds)
Comment 12 Tomas Danek 2011-02-07 15:40:04 UTC
http://hg.netbeans.org/main-golden/rev/117f3404a6da , AFAIK bits on smetiste are built from main-golden.
I ran test on hudson4qe from testdist testdist-201102070000.zip against netbeans-trunk-nightly-201102070000-javase.zip
without any problems.
Comment 13 Alexander Pepin 2011-02-07 16:06:04 UTC
Our tests is a NB project and it fails even on clean command.

We execute:
NBHOME=/export/hudson/jobs/cnd-test-intel-S2/workspace/netbeans-7.0
ANTHOME=/export/home/netbeans-7.0/java/ant

${ANTHOME}/bin/ant -Dnbplatform.NBTestedBuild.netbeans.dest.dir=${NBHOME} -Dplatforms.JDK_1.6.home=/usr/jdk/jdk1.6.0_13  clean

and get:

taskdefs:
common-init:
projectized-common.basic-init:
basic-init:
files-init:
testuserdir-delete:
test-clean:
Scanning for modules in /export/hudson/jobs/cnd-test-intel-S2/workspace/netbeans-7.0/nb
Scanning for modules in /export/hudson/jobs/cnd-test-intel-S2/workspace/netbeans-7.0/platform
Scanning for modules in /export/hudson/jobs/cnd-test-intel-S2/workspace/netbeans-7.0/cnd
Scanning for modules in /export/hudson/jobs/cnd-test-intel-S2/workspace/netbeans-7.0/dlight
Scanning for modules in /export/hudson/jobs/cnd-test-intel-S2/workspace/netbeans-7.0/ide
Scanning for modules in /export/hudson/jobs/cnd-test-intel-S2/workspace/netbeans-7.0/harness
Scanning for modules in suite /home/ap153252/ifdef_testbase/testbase_ide/testbase
/export/hudson/jobs/cnd-test-intel-S2/workspace/netbeans-7.0/harness/common.xml:1013: The following error occurred while executing this line:
/export/hudson/jobs/cnd-test-intel-S2/workspace/netbeans-7.0/harness/common.xml:1006: No dependent module org.netbeans.libs.junit4
BUILD FAILED (total time: 2 seconds)
Comment 14 Jesse Glick 2011-02-07 16:14:48 UTC
(In reply to comment #13)
> ant -Dnbplatform.NBTestedBuild.netbeans.dest.dir=${NBHOME}

This has nothing to do with testdist. The harness cluster as distributed no longer includes libs.junit4; you cannot run tests in an external module unless and until libs.junit4 is installed into the target platform. So your tests will need to be modified.
Comment 15 Alexander Pepin 2011-02-07 16:32:28 UTC
Could you please help us, how should we modify our tests?

Why org.netbeans.libs.junit4 is not included into zip any more? 
I would understand if junit-4.8.2.jar was required but why org-netbeans-libs-junit4.jar?
Comment 16 Jesse Glick 2011-02-07 16:40:25 UTC
(In reply to comment #15)
> Could you please help us, how should we modify our tests?

Download and install org-netbeans-libs-junit4.nbm from somewhere.

> I would understand if junit-4.8.2.jar was required but why
> org-netbeans-libs-junit4.jar?

libs.junit4 has no function besides wrapping junit-4.8.2.jar; in the Ant harness, module test dependencies must be on named modules.
Comment 17 Jesse Glick 2011-02-07 17:05:41 UTC
(In reply to comment #16)
> Download and install org-netbeans-libs-junit4.nbm from somewhere.

As of core-main #a6536dfe3b4b it should suffice to make sure JUnit 4.8.2 is present in the local Maven repo, which may be more convenient.