This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Hi, from time to time it seems that the TimableEventQueue enters an "illegal" state and logs a warning "Still previous controller ..." (Line 188). Cause: 1) "Watch Dog" task is scheduled by call to method "tick" (start time set) 2) Method "done" is called and finished, but canceling the task has failed. -> Task just starts running (removed from queue), but "run" method is not entered yet. Variable "stoppable" is not set yet. -> variable "stoppable" is reseted to "null" by "done" method 3) Task enters "run" method, starts self sampling and sets variable "stoppable" = this 4) Task is scheduled again by call to method "tick" (start time reseted) 5) Task enters "run" method, but variable "stoppable" is not "null" (it is still set to "previous" task) -> Log: Warning: "Still previous controller ..." -> (previous) self sampling still running 6) Method "done" is called after second event has been dispatched. -> if fast dispatch (time <= QUANTUM) self sampling keeps running. (memory and performance leak) -> else self sampling stopped, but slowness report with combined sampling data of all dispatched events between event from 1) and event from 4) I'm not sure if my investigation and all of my implications are right, but I attach a patch that will at least fix the warning. Regards Florian
Created attachment 103301 [details] Fix synchronization in TimableEventQueue
Your analysis makes sense. Thanks for the fix: core-main#e362b7085285
However the fix breaks the test: http://deadlock.netbeans.org/hudson/job/NB-Core-Build/lastCompletedBuild/testReport/org.netbeans.core/TimableEventQueueTest/testDispatchEvent/
Test failure addressed in core-main#ccc12e53266c
Integrated into 'main-golden', will be available in build *201011260001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/e362b7085285 User: Jaroslav Tulach <jtulach@netbeans.org> Log: #192427: Insufficient synchronization in TimableEventQueue by fvogler@netbeans.org
Credits: core-main#d28d89bedf6b
Integrated into 'main-golden', will be available in build *201011300001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/d28d89bedf6b User: Jaroslav Tulach <jtulach@netbeans.org> Log: #192427: Credits for Florian
*** Bug 192968 has been marked as a duplicate of this bug. ***