This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 191313 - Maven quick search provider: do not create new indices; deprioritize NB repo
Summary: Maven quick search provider: do not create new indices; deprioritize NB repo
Status: RESOLVED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Maven (show other bugs)
Version: 6.x
Hardware: All All
: P2 normal (vote)
Assignee: Antonin Nebuzelsky
URL:
Keywords: PERFORMANCE
Depends on:
Blocks: 190448
  Show dependency tree
 
Reported: 2010-10-25 14:45 UTC by Jan Becicka
Modified: 2010-10-29 03:00 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Results for "Test" (17.94 KB, image/png)
2010-10-25 14:46 UTC, Jan Becicka
Details
Results for "Spring" (14.39 KB, image/png)
2010-10-25 14:47 UTC, Jan Becicka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Becicka 2010-10-25 14:45:35 UTC
Maven quick search provider should be removed from the IDE:
1. It is slow. It starts to download various indexes from web, which can take several minutes
2. It does not have useful results. See attached maven search results for "Test" and "Spring" keyword. These results are useless.
3. [my personal opinion] Quick search was always meant as a tool for searching things inside of the IDE. Maven is not that kind of search.
Comment 1 Jan Becicka 2010-10-25 14:46:42 UTC
Created attachment 102616 [details]
Results for "Test"
Comment 2 Jan Becicka 2010-10-25 14:47:25 UTC
Created attachment 102617 [details]
Results for "Spring"
Comment 3 Jesse Glick 2010-10-25 16:35:08 UTC
(In reply to comment #0)
> starts to download various indexes from web

Must be fixed to only search from indices which are already prepared.

> See attached maven search results for
> "Test" and "Spring" keyword. These results are useless.

"Test" is fine (shows junit artifact), but "Spring" shows results from NB repo, which should probably be searched last since this repo has poor repackagings of various libraries.

> Quick search was always meant as a tool for searching
> things inside of the IDE

It covers Go to Type, the Ant manual, etc.
Comment 4 Jesse Glick 2010-10-25 16:35:51 UTC
Adjusting summary accordingly.
Comment 5 Jan Becicka 2010-10-26 10:06:41 UTC
> > Quick search was always meant as a tool for searching
> > things inside of the IDE

> It covers Go to Type, the Ant manual, etc.

Yes. Types defined in projects opened in the IDE. 
Ant manual is searched, if it is locally installed in the IDE, right?
-------

Maven results are also ugly. Improve it's appearance. It is not clear what those results represent...
Comment 6 Antonin Nebuzelsky 2010-10-26 13:36:35 UTC
regarding performance - in the past (6.7) the provider was already fixed (issue #165248) to not do anything if the user does not have *any* repository indexes available yet (i.e. the remote ones and the local repo's too), but if the user had at least the local repository index available already, the provider started searching in *all* registered repos and thus triggered download of the missing indexes and blocked quick search completely.
Comment 7 Jesse Glick 2010-10-26 19:49:51 UTC
(In reply to comment #3)
> Must be fixed to only search from indices which are already prepared.

Can in this case also remove current warning before using the provider, I guess.
Comment 8 Antonin Nebuzelsky 2010-10-27 21:39:42 UTC
core-main #34cf1bc19870

- removed the warning before using the provider
- not triggering downloading missing indexes, using only those available
- improved detection of repositories whose indexes are available for the search
- incrementally searching in the list of repos - the order is according to how they are registered (local, central, java.net2, netbeans)
- returning partial results after 5 seconds, in case search is still running after 5s
- removed FIELD_CLASSES (and FIELD_VERSION) from the search parameters - the results now don't include "strange" items which don't seem to map to the query - they did match to it because some class in the artifact did match but that may be confusing and too much detailed for Quick search - users can still search for classnames in libraries in other UI (maven repository browser, missing class hint in editor)

Honzo, in case you see some more space for improvement, let me know.
Comment 9 Quality Engineering 2010-10-29 03:00:42 UTC
Integrated into 'main-golden', will be available in build *201010290000* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/34cf1bc19870
User: Antonin Nebuzelsky <anebuzelsky@netbeans.org>
Log: #191313: performance of Maven quick search provider