This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 190409 - 22s - in org.openide.text.CloneableEditor.closeLast()
Summary: 22s - in org.openide.text.CloneableEditor.closeLast()
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Text (show other bugs)
Version: 6.x
Hardware: All All
: P3 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords: PERFORMANCE
: 199882 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-17 09:32 UTC by Exceptions Reporter
Modified: 2011-11-09 13:55 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter: 169342


Attachments
nps snapshot (33.63 KB, application/nps)
2010-09-17 09:32 UTC, Exceptions Reporter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Exceptions Reporter 2010-09-17 09:32:22 UTC
Build: NetBeans IDE 6.8 (Build 200912041610)
VM: Java HotSpot(TM) Client VM, 14.3-b01, Java(TM) SE Runtime Environment, 1.6.0_17-b04
OS: Windows XP

User Comments:
GUEST: I was opening the ide.



Maximum slowness yet reported was 22297 ms, average is 21391
Comment 1 Exceptions Reporter 2010-09-17 09:32:26 UTC
Created attachment 102055 [details]
nps snapshot
Comment 2 Jan Lahoda 2010-09-17 09:57:37 UTC
Unrelated to java.source, as far as I can tell - vast majority of the wall clock time (which is the important one in this case, right?) is spent in o.o.text.CloneableEditor.closeLast(). This is IMO a direct consequence of fixing bug #163236 (which is a consequence of background opening of the editor) - the closeLast method most likely waits on the CLOSE_LAST_LOCK. Assigning to platform/text and Jarda, who knows most about the lazy opening.
Comment 3 Jaroslav Tulach 2010-09-17 15:19:01 UTC
I'd rather see a bit more activity of the default owner of openide.text instead of seeking for reasons why code written by Marek shall be fixed by me.
Comment 4 David Strupl 2010-09-17 16:02:51 UTC
Who is "the default owner of openide.text"? I don't have the administrative rights for platform component ... It used to be Vita AFAIK so we have to find out the new owner before you can actually request "more activity" from him/her. I am putting the responsible managers on Cc: so they can decide who will take over issues like this one in the future
Comment 5 Jaroslav Tulach 2010-09-29 05:57:19 UTC
As far as I understood the owner is editor team (as QA contact field indicates). So David, Martin, just pick one of your team members up. Let me know by end of September 2010 who's that going to be.
Comment 6 David Strupl 2010-09-30 14:15:29 UTC
I hope that we have made it by the end of Sept: as you already know (and agreed) it will be yourself, I am mentioning it here for the other folks ...
Comment 7 Jaroslav Tulach 2010-10-01 09:37:42 UTC
Either you need to define what "we" means, or you are confused. Talk to Martin Ryzl to learn what he negotiated before making premature announcements. PS: I am writing it here so other people are not confused by comments #6 and rather ignore it.
Comment 8 David Strupl 2010-10-01 10:54:30 UTC
I sincerely apologize for the confusion (by "we" I meant Martin and me but I am confused as you wrote). I am removing myself from Cc: of this bug and from now on please handle it between yourself, Martin and John. The only thing I know for sure is that I am not owner of platform/text and that is all I need to know.
Comment 9 Jaroslav Tulach 2010-11-23 11:47:07 UTC
core-main#dfad51d7ec71
Comment 10 Vladimir Voskresensky 2010-11-23 13:07:52 UTC
imho, using AtomicBoolean produces nicer code than with new boolean[1] :-)
Comment 11 Jaroslav Tulach 2010-11-23 13:22:09 UTC
I considered that too for a while. Then I sticked with old good boolean[1].
Comment 12 Quality Engineering 2010-11-24 06:14:49 UTC
Integrated into 'main-golden', will be available in build *201011240001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/dfad51d7ec71
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #190409: Don't hold lock while running long time operation. Just note that the support shall be closed and do it when the long running operation is over
Comment 13 Jan Lahoda 2011-11-09 13:55:48 UTC
*** Bug 199882 has been marked as a duplicate of this bug. ***