This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 189671 - Uninstall does not remove updates
Summary: Uninstall does not remove updates
Status: VERIFIED FIXED
Alias: None
Product: installer
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P2 normal (vote)
Assignee: Yulia Novozhilova
URL:
Keywords:
: 190384 196388 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-19 08:16 UTC by Egor Ushakov
Modified: 2011-07-25 08:05 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Wording and placement proposal. (49.01 KB, image/png)
2011-05-27 11:21 UTC, jrojcek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Egor Ushakov 2010-08-19 08:16:44 UTC
steps to reproduce:
 - install Netbeans
 - update it with the update center
 - uninstall Netbeans
Installation folder will not be removed and will still contain updates files.
Maybe uninstaller could ask user if he wants to remove install dir? (like it does for user dir).
Comment 1 dlipin 2010-09-17 06:31:23 UTC
*** Bug 190384 has been marked as a duplicate of this bug. ***
Comment 2 Ondrej Vrabec 2011-03-07 11:05:08 UTC
*** Bug 196388 has been marked as a duplicate of this bug. ***
Comment 3 Marian Mirilovic 2011-03-18 11:47:41 UTC
Ok, so for NB 7.0 and newer it becomes more strange, because junit libs are installed as add-ons and stays in the uninstaled IDE. I understand that we didn't change it in NB 7.0 due to short time(so waiving for NB 7.0), but we need to deliver it in the next release.
Comment 4 Antonin Nebuzelsky 2011-05-19 11:47:12 UTC
Will we have a fix for 7.0.1 (a straightforward fix - a question in UI if user wants to remove all the files within the installdir) or does it deserve a more sophisticated solution?
Comment 5 Yulia Novozhilova 2011-05-19 13:15:06 UTC
I'm planning to fix it for 7.0.1
Comment 6 Yulia Novozhilova 2011-05-26 12:09:33 UTC
Integrated the fix to core-main.
The following wording is used for the checkbox:
"Remove the NetBeans IDE Installation Folder: {path to the installation dir}"

Please, let me know is the wording should be changed.
Comment 7 Peter Nabbefeld 2011-05-26 12:13:04 UTC
(In reply to comment #6)
> Integrated the fix to core-main.
> The following wording is used for the checkbox:
> "Remove the NetBeans IDE Installation Folder: {path to the installation dir}"
> 
> Please, let me know is the wording should be changed.

Probably, there could be displayed an additional hint like this:
"All globally installed modules will be removed."? Just for unexperienced users, so they'll better understand?
Comment 8 jrojcek 2011-05-26 14:29:06 UTC
To do it properly, the uninstaller would know about additionally installed updates/modules and uninstall them without asking. If the installer folder is empty after uninstalling NetBeans with additional updates/modules, the installer would delete it. That would mean there are no "unknown" files left in the folder that may be important for the user to keep.

If we ask the user to make decision, majority of users would have to deal with a question that has obvious answer to them (yes). Some my know they don't want to delete it, and the rest would forget they have important files in the NetBeans installation folder and would delete them.

Is it too difficult to do it properly?
Comment 9 Peter Nabbefeld 2011-05-26 14:35:04 UTC
(In reply to comment #8)

> Is it too difficult to do it properly?

Please be more polite - at least she now wants to fix this problem, which caused several strange problems, at least for me.
Comment 10 jrojcek 2011-05-26 14:52:03 UTC
I apologize if it sounded impolite. That wasn't my intention. I understand if there are technical difficulties to do the uninstallation automatically. I just wanted to stress the correct behavior from user perspective.
Comment 11 Yulia Novozhilova 2011-05-26 15:21:29 UTC
Jan, you are right, but the "correct" implementation requires an integration of the Installer and Autoupdate (#54182). It is decided not to spend resources for implementation of this enhancement now. So I'm trying to fix the problem in a more straightforward way. So a lot depends on the wording we use in uninstaller.
Comment 12 jrojcek 2011-05-27 11:21:07 UTC
Created attachment 108546 [details]
Wording and placement proposal.
Comment 13 jrojcek 2011-05-27 11:23:51 UTC
Ccing Ken. Ken, please review the wording in the attached PNG. It provides an option to delete the NetBeans installation folder.
Comment 14 Quality Engineering 2011-05-27 11:54:22 UTC
Integrated into 'main-golden', will be available in build *201105270401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/8ae4626bafc6
User: Yulia Novozhilova <ynov@netbeans.org>
Log: Fix #189671 -  Uninstall does not remove updates
Comment 15 Kenneth Ganfield 2011-05-27 16:09:20 UTC
I would suggest the following wording.
I would also suggest combining the 3 options so that there are only 2 lists of items, but Jan or others might have their reasons for keeping the lists separate.
There could also be a checkbox to quickly select all.


Click Uninstall to start the uninstallation process.


....


Remove the following runtimes during the uninstallation process.
[] ...


Delete the following folders during the uninstallation process.
[] NetBeans installation folder.
   The NetBeans installation folder might contain updates and plugins
   that were installed after the initial installation. The folder might also 
   contain some user files or additional files added by a third party.

[] NetBeans user folder (userdir) at ...
   The NetBeans user folder contains the configuration data for the IDE.
   For more information about ...
Comment 16 Egor Ushakov 2011-05-27 16:29:17 UTC
one comment: please do not ask about NetBeans installation folder (even do not show the checkbox) if there are no suspicious files left in it. It will avoid confusion at least for user without installed plugins.
Comment 17 Quality Engineering 2011-06-07 06:30:46 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/
User: 
Log:
Comment 18 Marian Mirilovic 2011-06-10 08:12:45 UTC
Hmm, it works as expected in Dev (201106080600) ... I saw an integration into release701 already, but we do not have a new build from 7.0.1, then I'll verify. 

BTW: is there any reason this issue is not marked as FIXED yet ?
Comment 19 Quality Engineering 2011-06-11 04:19:39 UTC
Integrated into 'releases'
Changeset: http://hg.netbeans.org/releases/rev/ce4a7c904fc6
User: Yulia Novozhilova <ynov@netbeans.org>
Log: Fix #189671 -  Uninstall does not remove updates