This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 189012 - Server plugin SPI to request deployment descriptor creation
Summary: Server plugin SPI to request deployment descriptor creation
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 7.0
Hardware: PC All
: P3 normal (vote)
Assignee: Petr Hejl
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks: 188723
  Show dependency tree
 
Reported: 2010-07-28 11:57 UTC by Petr Hejl
Modified: 2011-11-29 09:59 UTC (History)
3 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Hejl 2010-07-28 11:57:26 UTC
Certain servers require deployment descriptor even if it is not required by the specification. There should be a way for plugin to report that.
Comment 1 Petr Hejl 2010-07-28 12:36:32 UTC
I already pushed the change to web-main 3dd074f7fca4. I'll adapt the change in case there will be any objections.

http://hg.netbeans.org/web-main/rev/3dd074f7fca4
Comment 2 Petr Hejl 2010-07-28 12:37:31 UTC
Please review.
Comment 3 David Konecny 2010-07-28 20:19:30 UTC
DK01 - you turned add/remove listener methods in spi/J2eeModuleProvider.java public but patch does not uses them anyway. Was that intentional?

DK02 - this new API will be used only during project creation right? It will not catch cases when project is created for GF and deployed to Weblogic. Switching server is corner case scenario though so perhaps it is not an issue.
Comment 4 Petr Hejl 2010-07-28 20:36:58 UTC
(In reply to comment #3)
> DK01 - you turned add/remove listener methods in spi/J2eeModuleProvider.java
> public but patch does not uses them anyway. Was that intentional?

It is intentional, but should not be part of the patch. Note that there is no real change as these methods are declared in interface. The change was made just to make them consistent with other methods in the interface which are explicitly declared public.

> 
> DK02 - this new API will be used only during project creation right? It will
> not catch cases when project is created for GF and deployed to Weblogic.

It will. It handles the server change. Note that the whole machinery works for EAR only as it is now. I'm not sure whether it is worth to implement for other project types unless it is really needed (should be easy for web, not sure about ejb and appclient).

> Switching server is corner case scenario though so perhaps it is not an issue.
I agree.