This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 186291 - Deadlock in external-change detection
Summary: Deadlock in external-change detection
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Filesystems (show other bugs)
Version: 6.x
Hardware: Macintosh (x86) Mac OS X
: P1 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
: 186732 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-05-18 11:11 UTC by emcmanus
Modified: 2010-05-27 11:39 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
jstack output when NetBeans was deadlocked (25.16 KB, text/plain)
2010-05-18 12:01 UTC, emcmanus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description emcmanus 2010-05-18 11:11:03 UTC
I encountered a deadlock with a dev build of NB 6.9 (100514-539d9a81eb38) after changing some files externally. The jstack output is attached.
Comment 1 Peter Pis 2010-05-18 11:57:04 UTC
Could you please attach the output?
Comment 2 emcmanus 2010-05-18 12:01:11 UTC
Created attachment 99129 [details]
jstack output when NetBeans was deadlocked

Hmmm, I thought I had.
Comment 3 Tomas Zezula 2010-05-18 12:25:01 UTC
platform/fs
Comment 4 Tomas Zezula 2010-05-18 12:26:06 UTC
Probably duplicate of http://netbeans.org/bugzilla/show_bug.cgi?id=185900
Comment 5 Jaroslav Tulach 2010-05-24 11:59:51 UTC
I wish it was duplicate. But this one is more serious, it shows that events are delivered under the "idleIO" mode and as such any code which reacts to them is also running in idleIO mode.

Possibly P1, depends how often this problem happens. Another question to ask is why the code does not leave the waitIOLoad method? After a while the load shall drop down, shall it not?
Comment 6 Jaroslav Tulach 2010-05-24 16:56:25 UTC
Fixed in core-main#9519a4901110.

I am not sure what are the next steps and whether this needs to be fixed for 6.9. However the code shall not be better than it was before.

If you decide to merge to 6.9 then Tonda please:

hg pull -r 9519a4901110 http://hg.netbeans.org/core-main/
hg merge
Comment 7 Antonin Nebuzelsky 2010-05-24 19:01:34 UTC
> I am not sure ...whether this needs to be fixed for 6.9.
> However the code shall not be better than it was before.

Not better than before? Not sure if for 6.9?

If the report shows that "events are delivered under the idleIO mode and as such any code which reacts to them is also running in idleIO mode" and the patch fixes it, it should prevent the deadlock and we want to have it integrated in 6.9 IMO.

Or can the change lead to some other problems?

Can someone do a review for you?

Let's wait with backport to release69 after this is more clear.
Comment 8 Quality Engineering 2010-05-25 07:32:33 UTC
Integrated into 'main-golden', will be available in build *201005250001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/9519a4901110
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #186291: Delivering events from refreshSlow outside of idleIO block
Comment 9 Jaroslav Tulach 2010-05-25 12:17:55 UTC
"not be better" this should have been: "now be better". The only person that comes to my mind to do review is Tomáš Z.
Comment 10 Antonin Nebuzelsky 2010-05-26 11:48:01 UTC
Tomasi, can you review? Thanks.
Comment 11 Tomas Zezula 2010-05-26 16:00:16 UTC
I don't have so deep knowledge of master fs. Jarda explained me what the patch does and it seems compatible with Jarda description. The patch is probably OK.
Comment 12 Antonin Nebuzelsky 2010-05-27 11:35:45 UTC
Backported to release69 for RC2.
Comment 13 Tomas Zezula 2010-05-27 11:39:06 UTC
*** Bug 186732 has been marked as a duplicate of this bug. ***