Bug 185809 - Make OptionalDeploymentManagerFactory.getAddInstanceIterator() abstract
Make OptionalDeploymentManagerFactory.getAddInstanceIterator() abstract
Status: REOPENED
Product: serverplugins
Classification: Unclassified
Component: Code
6.x
PC Mac OS X
: P3 (vote)
: TBD
Assigned To: issues@serverplugins
issues@serverplugins
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-09 21:29 UTC by jlaskowski
Modified: 2010-05-12 05:57 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jlaskowski 2010-05-09 21:29:34 UTC
I would've spared a couple of days wondering why my plugin didn't display a new server definition in the Add Server wizard if the OptionalDeploymentManagerFactory.getAddInstanceIterator() method had not returned null (and I had known I should've override it).
Comment 1 Petr Hejl 2010-05-10 13:38:00 UTC
That would be incompatible API change.
Comment 2 jlaskowski 2010-05-10 20:29:28 UTC
I don't mean to play "do this vs I won't because I said so" game, but would you consider a change that would eventually helped pinpoint such an issue that a user is stuck with debugging trying to figure out what methods are responsible for a given task, i.e. the aforementioned method for showing a new server entry in the Add Server panel. WDYT? Close it if you think it's not doable.
Comment 3 Petr Hejl 2010-05-11 13:43:52 UTC
It is enhancement. Feel free to attach patch that will preserve API compatibility.
Comment 4 jlaskowski 2010-05-11 22:23:20 UTC
What about throwing a RuntimeException as a default implementation with a meaningful message why it's important to override it?
Comment 5 Petr Hejl 2010-05-12 05:57:25 UTC
You still suppose that it is mandatory to implement this method. The plugin is not required to provide the wizard (such as different embedded runtimes etc.). You would immediately break such plugins with your change.


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo