This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 185235 - Need a way to specify exact connector
Summary: Need a way to specify exact connector
Status: RESOLVED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Java (show other bugs)
Version: 6.x
Hardware: PC Windows XP
: P1 normal (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks: 185232 185242
  Show dependency tree
 
Reported: 2010-04-29 09:16 UTC by Martin Ryzl
Modified: 2010-05-14 04:08 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
suggested patch (5.79 KB, patch)
2010-05-03 15:56 UTC, Martin Ryzl
Details | Diff
better patch (5.89 KB, application/octet-stream)
2010-05-12 09:00 UTC, Martin Ryzl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Ryzl 2010-04-29 09:16:07 UTC
To improve debugging of JavaFX applications a new FXJDI proxy has been introduced. By default the proxy will delegate on standard JDI, providing JavaFX specific behavior in certain cases:
- name mangling/de-mangling
- handling of lazy binding
- removing synthetic frames

The proxy is supposed to be compatible with java applications.

FXJDI provides additional connectors - they simply delegate on existing connectors. We need a way how to specify exact connector instead of just taking first one which implements given transport.
Comment 1 Martin Ryzl 2010-05-03 15:56:04 UTC
Created attachment 98382 [details]
suggested patch
Comment 2 Martin Entlicher 2010-05-11 13:58:17 UTC
The patch looks O.K., I'm going to integrate it...
Comment 3 Martin Ryzl 2010-05-12 09:00:53 UTC
Created attachment 98822 [details]
better patch

patch to better handle current implementation of fxjdi - lookup should look for Connector class rather than ListeningConnector.
Comment 4 Martin Entlicher 2010-05-12 12:08:40 UTC
I've already committed the first patch as changeset:   170616:62c87fcb4fde
http://hg.netbeans.org/main/rev/62c87fcb4fde

The second patch just looks for objects implementing Connector and then extracts those that implement ListeningConnector. This looks strange, why is it needed?
Comment 5 Martin Entlicher 2010-05-12 15:02:52 UTC
Using Connector class in the Lookup in changeset:   170633:8dc8766b7183
http://hg.netbeans.org/main/rev/8dc8766b7183
Comment 6 Quality Engineering 2010-05-14 04:08:38 UTC
Integrated into 'main-golden', will be available in build *201005132200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/
User: 
Log: