This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 18490 - I18N - VCS Group Name does not support multi-byte
Summary: I18N - VCS Group Name does not support multi-byte
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: Sun Solaris
: P2 blocker (vote)
Assignee: Milos Kleint
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2001-12-10 09:08 UTC by Keiichi Oono
Modified: 2003-07-01 12:57 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Screenshot when reproducing (19.52 KB, image/jpeg)
2001-12-10 09:12 UTC, Keiichi Oono 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keiichi Oono 2001-12-10 09:08:40 UTC 
To reproduce:
    - Create VCS Group which has Japanese name

When I use Japanese name for VCS Group, that Japanese name is not displayed
correctly. However, I can add Japanese Classes under that group. Please see
attached file for image. However, I can add Japanese classes under that Japanese
VCS group.
I've also checked generated file under nbdev/system/vcs/Groups. The contents of
gourp_X.properties is saved correctly with system default encoding.
Comment 1 Keiichi Oono 2001-12-10 09:12:47 UTC 
Created attachment 3749 [details]
Screenshot when reproducing
Comment 2 Keiichi Oono 2001-12-10 09:18:10 UTC 
When I select "Add to VCS Group, the listed group names are not
displayed correctly as same as VCS Groups window.
Comment 3 Milos Kleint 2001-12-10 09:24:27 UTC 
reassigning to vcscore
Comment 4 Milos Kleint 2001-12-10 09:45:09 UTC 
So you've checked that the name is correctly written but badly read,
right?

Here's the proposed change to the file reading code that should IMHO
fix the problem:
(adding the Locale.getDefault() params to the Bundle.getString() calls.)


ResourceBundle bundle = new 
              PropertyResourceBundle(propsFo.getInputStream());
groupName = bundle.getString(PROP_NAME, Locale.getDefault());
groupDescription = bundle.getString(PROP_SHORT_DESCRIPTION, 
                   Locale.getDefault());
groupDescription = 
      org.openide.util.Utilities.replaceString(groupDescription, "\\n",  
                                               "\n"); //NOI18N
Comment 5 Milos Kleint 2001-12-10 09:55:46 UTC 
Ops. forget the previous item, I confused getBundle and getString
methods..
Comment 6 Milos Kleint 2001-12-10 14:21:20 UTC 
fixed in main trunk and release33 branch. (should appear in dev build
on 11/Dec/2001)
Please verify however, I haven't tried with japanese settings..
Comment 7 Jiri Kovalsky 2001-12-11 08:30:19 UTC 
Could you please Keiichi verify whether the fix was successfull ? 
Thank you !
Comment 8 Keiichi Oono 2001-12-11 09:32:49 UTC 
Thank you very much for your quick fixing!
I've verified on Build 200112110331. The VCS Groups dialog has been
fixed, but when I select the "Add to VCS Group" by right button
clicking on Class Icon, the menu string is corrupted, and I can't add
my class to Japanese group. Could you also fix it?
Comment 9 Milos Kleint 2001-12-11 09:37:42 UTC 
*nods* I'll fix that as well, I thought the file is read on one place
only, but forgot about this second place, sorry.
Comment 10 Milos Kleint 2001-12-11 10:24:06 UTC 
should be done in main trunk and release33 branch. Appears in dev
build on 12/Dec/2001.
Comment 11 Jiri Kovalsky 2001-12-12 09:28:40 UTC 
Is it okay now Keiichi ?
Comment 12 Keiichi Oono 2001-12-12 12:01:38 UTC 
Sorry for my late update. I've just verified and have confirmed all of
these issues have been fixed.
I've verified on 3.3.1 dev build (200112120331).
Thank you!
Comment 13 Jesse Glick 2002-12-23 16:35:56 UTC 
Consistent use of the I18N keyword.
Comment 14 Quality Engineering 2003-07-01 12:57:38 UTC 
Resolved for 3.4.x or earlier, no new info since then -> closing.