This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 184229 - Deadlock from ToggleBookmarkAction
Summary: Deadlock from ToggleBookmarkAction
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Actions/Menu/Toolbar (show other bugs)
Version: 6.x
Hardware: Other Linux
: P3 normal (vote)
Assignee: issues@editor
URL:
Keywords: RANDOM, THREAD
Depends on:
Blocks:
 
Reported: 2010-04-15 08:39 UTC by Jaroslav Tulach
Modified: 2010-04-21 04:38 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2010-04-15 08:39:53 UTC 
Tim's report #182960 shows a deadlock:
https://netbeans.org/bugzilla/attachment.cgi?id=96014

The AWT thread is blocked by EditorCookie.getOpenedPanes() called from 
at org.netbeans.lib.editor.bookmarks.actions.ToggleBookmarkAction.findComponent(ToggleBookmarkAction.java:147)

that call shall be replaced by new and non-blocking:
http://bits.netbeans.org/dev/javadoc/org-openide-text/org/openide/text/NbDocument.html#findRecentEditorPane(org.openide.cookies.EditorCookie)
Comment 1 Vitezslav Stejskal 2010-04-19 20:03:19 UTC 
http://hg.netbeans.org/jet-main/rev/71cdbdf5186c
Comment 2 Quality Engineering 2010-04-21 04:38:19 UTC 
Integrated into 'main-golden', will be available in build *201004210200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/71cdbdf5186c
User: Vita Stejskal <vstejskal@netbeans.org>
Log: #182249, #184229: using faster and non-blocking NbDocument.findRecentEditorPane rather than EditorCookie.getOpenedPanes