This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Perhaps as a consequence of the new editor view hierarchy, Mercurial change markers appear on the wrong line. For example, with starting code /** * XXX */ public class C { and new code /** * XXX * foo */ public class C { the green bar appears next to " */" rather than " * foo" as expected. (May be a side effect of bug #182504.)
Reassigning to editor for evaluation. Does editorUI return the correct value of lineHeight? When i decrease the returned value of lineHeight by a certain constant, markers seem to be correctly placed. However the constant differs in dependence on value of --fontsize. Should we deal with the changes in diff or can this be fixed in editor? The relevant code computing diff marker positions is in http://hg.netbeans.org/cdev/file/2ba51d984c07/versioning/src/org/netbeans/modules/versioning/diff/DiffSidebar.java#l651
I've also noticed that there are small spaces between lines in editor, maybe it's related to this issue.
Created attachment 95892 [details] spaces between lines
*** Bug 182903 has been marked as a duplicate of this bug. ***
*** Bug 183057 has been marked as a duplicate of this bug. ***
Local-History Line is also wrong.
*** Bug 183093 has been marked as a duplicate of this bug. ***
*** Bug 183090 has been marked as a duplicate of this bug. ***
This works now better after http://hg.netbeans.org/jet-main/rev/53af119ca970. If linewrap setting is off the diff sidebar works fine. The problem is when linewrap is on and there are lines in the document that are wrapped. In that case the diff marks are completely misaligned. The reason for that is that with linewrap on lines have no longer the same height. This needs to be changed in the diff sidebar. Specifically, any code using EditorUI.getLineHeight() or EditorUI.getAscent() needs to be reviewed and fixed.
Well I can see it still for mercurial but can't reproduce it anymore for CVS. It is no more so easy to reproduce it for mercurial but I saw it happens again today. Build 100331-eb8d22d7ddd4. BTW, for another kind of annotations as hint, debugger breakpoint and so on it is still valid as in attached image, but this is the case for another issue IMO.
Created attachment 96550 [details] Sample image
fix in vcs annotation bar: http://hg.netbeans.org/cdev/rev/85bd70d858c7
fix in diff sidebar: http://hg.netbeans.org/cdev/rev/99cd74f0dcfb
fix in diff panel: http://hg.netbeans.org/cdev/rev/92fc8b30f2e5
final fix for diff sidebar: http://hg.netbeans.org/cdev/rev/22420a9b0be5
final fix for diff panel: http://hg.netbeans.org/cdev/rev/c988963419bd
*** Bug 183017 has been marked as a duplicate of this bug. ***
*** Bug 183441 has been marked as a duplicate of this bug. ***
*** Bug 182872 has been marked as a duplicate of this bug. ***
Integrated into 'main-golden', will be available in build *201004090201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/85bd70d858c7 User: Ondrej Vrabec <ovrabec@netbeans.org> Log: Issue #182810 - [69cat] Change gutter marks on wrong line