This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 181209 - Extend API/SPI: ability to create enhanced multi-view diff
Summary: Extend API/SPI: ability to create enhanced multi-view diff
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Diff (show other bugs)
Version: 6.x
Hardware: All All
: P3 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks: 103664
  Show dependency tree
 
Reported: 2010-02-25 08:09 UTC by Ondrej Vrabec
Modified: 2010-03-08 11:21 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
API/SPI changes and implementation (25.28 KB, patch)
2010-02-25 08:14 UTC, Ondrej Vrabec
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ondrej Vrabec 2010-02-25 08:09:28 UTC
So that we can satisfy demands in bug 103664, we need to add new methods to the Diff API/SPI. Currently the diff visualizer only displays the graphical diff window, i would like to add also a textual representation of the diff to the visualizer so that for small changes made to a file you don't have to scroll in relatively huge graphical diff and see the change immediately as few lines long text.

Why do we have to change the API/SPI?
103664 could be fixed even without the API/SPI change, it would mean that the diff visualizer would always display both views (graphical and textual). But i think this change in UI would disappoint many clients currently using the diff support (e.g. Refactoring, i think it has no need to display the textual diff and wants to display the diff in the current form).
So i think the best is to vreate a new factory method in org.netbeans.api.diff.DiffController (createEnhanced) and tunnel the request to the SPI in org.netbeans.spi.diff.DiffControllerProvider.createEnhancedDiffController
Comment 1 Ondrej Vrabec 2010-02-25 08:14:59 UTC
Created attachment 94513 [details]
API/SPI changes and implementation
Comment 2 Ondrej Vrabec 2010-03-03 02:39:37 UTC
If there are no objections, i will integrate into cdev tomorrow.
Comment 3 Ondrej Vrabec 2010-03-04 08:28:23 UTC
fix: http://hg.netbeans.org/cdev/rev/d31ef4b9e538
Comment 4 Quality Engineering 2010-03-08 11:21:25 UTC
Integrated into 'main-golden', will be available in build *201003081350* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/d31ef4b9e538
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: Issue #181209 - Extend API/SPI: ability to create enhanced multi-view diff