This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 180821 - setCurrentSubcategory not friendly to composite controllers
Summary: setCurrentSubcategory not friendly to composite controllers
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Options&Settings (show other bugs)
Version: 6.x
Hardware: PC Linux
: P3 normal (vote)
Assignee: Theofanis Oikonomou
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2010-02-17 03:23 UTC by Jan Lahoda
Modified: 2013-12-04 02:45 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
proposed fix (4.47 KB, patch)
2013-11-26 15:09 UTC, Theofanis Oikonomou
Details | Diff
proposed fix (5.44 KB, patch)
2013-11-26 15:12 UTC, Theofanis Oikonomou
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Lahoda 2010-02-17 03:23:32 UTC
[recent sources]

Consider an OptionsPanelController, that shows some sub-panels, for example FolderBasedController in options.editor. Such composite controller can implement the setCurrentSubcategory method for itself (to select the correct sub-panel), but cannot pass the remainder of the selection path to the sub-panel, as the setCurrentSubcategory is protected (and FolderBasedController is not in the same runtime package).

A usecase for this are Java hints: for each Java hint, there should be an option to configure the hint, which should open the Options dialog and pre-select the correct hint.

Possible solutions include creating a new public final method in OptionsPanelController, that would delegate to setCurrentSubcategory.
Comment 1 Theofanis Oikonomou 2013-11-26 15:09:10 UTC
Created attachment 142606 [details]
proposed fix

Added new public final method in OptionsPanelController that merely delegates to OptionspanelController.setCurrentSubcategory method.
Comment 2 Theofanis Oikonomou 2013-11-26 15:10:07 UTC
Please review this simple change. Thank you
Comment 3 Theofanis Oikonomou 2013-11-26 15:12:54 UTC
Created attachment 142607 [details]
proposed fix

updating also options.editor dependency and spec version
Comment 4 Theofanis Oikonomou 2013-12-02 10:00:42 UTC
If there are no comments I am planning to integrate tomorrow. Thank you
Comment 5 Theofanis Oikonomou 2013-12-03 09:44:55 UTC
Changeset: 1f8c27433957
Author:    Theofanis Oikonomou <theofanis@netbeans.org>
Date:      2013-12-03 10:45
Message:
Comment 6 Quality Engineering 2013-12-04 02:45:26 UTC
Integrated into 'main-silver', will be available in build *201312040002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/1f8c27433957
User: Theofanis Oikonomou <theofanis@netbeans.org>
Log: Task #180821 - setCurrentSubcategory not friendly to composite controllers