This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 18067 - Several NPEs are sometimes thrown when unmounting filesystem.
Summary: Several NPEs are sometimes thrown when unmounting filesystem.
Status: CLOSED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: CVS (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P3 blocker (vote)
Assignee: Milos Kleint
URL:
Keywords:
: 18152 18194 18195 18222 18342 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-11-23 17:12 UTC by Jiri Kovalsky
Modified: 2007-01-04 17:14 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
One of those exceptions while unmounting filesystem. (3.58 KB, text/plain)
2001-11-23 17:13 UTC, Jiri Kovalsky
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Kovalsky 2001-11-23 17:12:30 UTC
Development build of NetBeans 3.3 #200111230645 on Windows 2000 with JDK 1.4b87

Description:
============
I appologize for not having a reproducable case but I have seen it at least twi-
ce within one hour. There are several NullPointerExceptions thrown when unmoun-
ting filesystem. However filesystem was unmounted successfully.

Here is what I usually do:
==========================
1. Mount CVS filesystem using Built-in Client.
2. Use "Versioning Explorer" for a while. Close it.
3. Invoke "CVS|Annotate" on some file and play with it. Close it.
4. Unmount this filesystem and the exceptions should be thrown.
Comment 1 Jiri Kovalsky 2001-11-23 17:13:33 UTC
Created attachment 3565 [details]
One of those exceptions while unmounting filesystem.
Comment 2 Milos Kleint 2001-11-27 09:00:34 UTC
fixed in main trunk and release33 branch. (28/Nov/2001 build)
Comment 3 Jiri Kovalsky 2001-11-28 13:24:44 UTC
Hm, it really seems to be fixed. In other words I didn't see it again 
not once in one hour. :-) Verified in development build of NetBeans 
3.4 #200111280100.
Comment 4 Jiri Kovalsky 2001-11-28 15:37:57 UTC
*** Issue 18152 has been marked as a duplicate of this issue. ***
Comment 5 Milos Kleint 2001-11-29 18:00:48 UTC
*** Issue 18195 has been marked as a duplicate of this issue. ***
Comment 6 Milos Kleint 2001-11-29 18:11:35 UTC
raising priority since it's serious issue. making it a 330 candidate fix.
Comment 7 Milos Kleint 2001-11-29 18:11:41 UTC
*** Issue 18194 has been marked as a duplicate of this issue. ***
Comment 8 Milos Kleint 2001-11-29 18:11:49 UTC
*** Issue 18194 has been marked as a duplicate of this issue. ***
Comment 9 Milos Kleint 2001-11-30 12:49:26 UTC
*** Issue 18222 has been marked as a duplicate of this issue. ***
Comment 10 Milos Kleint 2001-11-30 18:14:53 UTC
The problem arose by a merge of 2 fixes.

1. a month ago, I was fixing the enabling/disabling of the module. For
that reason I was putting weaklisteners to some places and also
rewrote the removeNotify() method in JavacvsVrsioningSystem where I
cleared references to the filesystem and it's cache. That is right
since once the filesystem is unmounted, there's no reason for the
reference to be kept around.

2. Lately I introduced the VCsRefresher class that does refreshing of
filesystem on the background. This refreshing is stopped when the
filesystem is unmounted, however if it's currently running it's not
interrupted. And that's the problem here. Sometimes calls to methods
that should be normally done only when the fs is mounted, are done
also after unmounting, but at that time the reference is cleared and
NPE is the result.

The fix is actually easy and straighforward. ON each place where the
filesystem or fscache variables are referenced, I check for the null
value.

The diff is attached.

http://javacvs.netbeans.org/source/browse/javacvs/src/org/netbeans/modules/cvsclient/versioning/JavaCvsVersioningSystem.java.diff?r1=text&tr1=1.14&r2=text&tr2=1.15&f=h
Comment 11 Milos Kleint 2001-12-03 09:58:48 UTC
integrated into the release330 branch as well.
Comment 12 Milos Kleint 2001-12-06 08:11:24 UTC
*** Issue 18342 has been marked as a duplicate of this issue. ***
Comment 13 Quality Engineering 2003-07-01 12:49:44 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.