This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 17995 - Mode created by user persist even if not necessary - Single Frame
Summary: Mode created by user persist even if not necessary - Single Frame
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: PC All
: P2 blocker (vote)
Assignee: David Simonek
URL:
Keywords: PERFORMANCE
Depends on:
Blocks: 18365
  Show dependency tree
 
Reported: 2001-11-22 17:19 UTC by Lukas Hasik
Modified: 2008-12-23 09:36 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
suggested patch, to be used with release33 branch (162.26 KB, patch)
2001-12-06 17:09 UTC, David Simonek 		Details | Diff
diff (9.58 KB, patch)
2001-12-06 17:12 UTC, David Simonek 		Details | Diff
commit log (1.19 KB, text/plain)
2001-12-07 15:15 UTC, David Simonek 		Details
projects zip (712.07 KB, application/zip)
2001-12-07 15:45 UTC, Lukas Hasik 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lukas Hasik 2001-11-22 17:19:41 UTC 
Steps to reproduce:
-undock Runtime tab from Explorer (New Single frame)
-dock Runtime back to Explorer
-undock it again

-New window name appears - Runtime_1 - it's caused by that mode Runtime still
persist -> it should be deleted immediately after closing the window.

Will it be fixed in beta6, Dafe ?
Comment 1 Jan Chalupa 2001-11-27 11:51:26 UTC 
Target milestone -> 3.3.1.
Comment 2 Jan Chalupa 2001-11-27 11:54:50 UTC 
Target milestone -> 3.3.1.
Comment 3 mslama 2001-11-29 14:53:15 UTC 
Single modes created by user should be deleted. Also DataObject should
be deleted if it already exists (IDE was restarted between creation
and deleting mode). Otherwise mode could come back when refresh on
modes will be performed. It will be fixed to release33 (NB 3.3.1).
Comment 4 Lukas Hasik 2001-12-05 15:28:57 UTC 
due to issue #18039, this issue is bigger problem - number of modes
still rise
P3->P2
Comment 5 David Simonek 2001-12-05 16:19:44 UTC 
I'm taking this one.
Comment 6 David Simonek 2001-12-06 17:06:53 UTC 
Hi guys, I'm attaching the patch that sould solve this problem.
Please, test if works correctly. It's verbose patch, will print some
information about what it is doing to the console, pay attention to
these debug prints.
Unfortunately, diff is rather big, so review will not be as easy.
Comment 7 David Simonek 2001-12-06 17:09:55 UTC 
Created attachment 3717 [details]
suggested patch, to be used with release33 branch
Comment 8 David Simonek 2001-12-06 17:12:18 UTC 
Created attachment 3718 [details]
diff
Comment 9 David Simonek 2001-12-07 15:14:06 UTC 
fixed in release33 branch. attaching commit log.
Comment 10 David Simonek 2001-12-07 15:15:05 UTC 
Created attachment 3737 [details]
commit log
Comment 11 David Simonek 2001-12-07 15:19:30 UTC 
fixed in release33.
Comment 12 Lukas Hasik 2001-12-07 15:39:29 UTC 
with this patch user-defined modes are not stored any more onm close.

One problem : if somebody start ide with NB33 userdir with old
user-def modes then IDe on start deletes and clears modes. This action
take a long time BUT it happens only once and then it works properly...

I'm attaching my testing project with 1000 user-defined modes, enjoy ;))
Comment 13 Lukas Hasik 2001-12-07 15:45:03 UTC 
Created attachment 3740 [details]
projects zip
Comment 14 David Simonek 2001-12-07 16:15:14 UTC 
last part of commit log below. Complete fix fixes both this bug and
18365, it's not easily possible to fix these two bugs separately.

Checking in WorkspaceImpl.java;
/cvs/core/src/org/netbeans/core/windows/WorkspaceImpl.java,v  <-- 
WorkspaceImpl.java
new revision: 1.85.2.3; previous revision: 1.85.2.2
done
Comment 15 Jan Zajicek 2001-12-11 11:32:30 UTC 
verified in release33 and in 330 too
Comment 16 Quality Engineering 2003-07-01 16:20:29 UTC 
Resolved for 3.4.x or earlier, no new info since then -> closing.