On build 200111080100:
1. Open dialog Tools/Options/Editing/Editor settings/Java Editor/Indentation
Engine or Tools/Options/Editing/Editor settings/Java Editor/Macros (open really
the dialog for changing the property, but do not click inside it).
2. Press F1 for help. Some generic (incorrect) page is shown.
3. Do not close the help window, use the "Help" button on the dialog to open
help. The correct page is shown.
4. The same applies if you will click into the dialog before invoking the help.
This is probably some kind of focus problem.
The original report is:
Jesse, it seems you know best about HelpAction :-)
*** Issue 5890 has been marked as a duplicate of this issue. ***
make sure to read the bug report #5890 (F1 does not receive correct
help from property sheet pane of docked Debugger view.) to get some
Is this really P2?? This seems like a P4 to me. Users are not even
likely to use F1 when there is an obvious Help button.
There appear to be two unrelated bugs here. For the Indentation Engine
dialog, the correct help appears everywhere except the property sheet.
This appears to be a regression in property sheet code, reproducible
without any dialog, just regular Explorer vs. Prop Sheet. Apparently
HelpAwareJTabbedPane is not doing its job anymore. Petr Z., you most
recently worked on property sheet; any idea?
For the macro dialog, certain parts of the dialog (the table cells and
the JButton's to the right) get help but the blank areas do not. I
will try to investigate what the problem is; the code in the editor
Yes, I was doing the HelpAwareTabbedPane.
I'm going to look at it.
OK, thanks. Assign back to me for the macro dialog part, I doubt that
Fixed the part with property sheet, assignig back the problem with
macro to Jesse.
Fix: openide/../openide/explorer/propertysheet/PropertySheet.java [1.73]
It seems the problem was the HelpAwareJTabbedPane tried to find the
HelpCtx passed from NodeProperty.Set.getValue("helpID") and if it
failed it returned the default HelpCtx. Instead of returning the
default one now it finds one from its parent which works for this case.
Jesse, if this is not correct step, please let me know.
Yes, the rule for help in prop sheets is supposed to be this: rows in
the sheet (both the sheet button and property panel) should get help
preferentially from N.P.helpID, failing that from N.PS.helpID, failing
that from the node; other areas in the tab should get help from the
N.PS.helpID, failing that from the node; other areas in the property
sheet outside the tabbed area should get help from the node. I'm
pretty sure that is what it did at some point, but it got broken (I
don't know when exactly, maybe during dstrupl's refactoring). I have a
low-priority task to write some unit tests for this stuff so it
doesn't get broken again.
Yes it was broken during the David's refactoring and when I was
putting it back, didn't recognize the clue from the old sources.
From your comment it seems the HelpAwareJTabbedPane would need
probably still some refinement. Will see when you make the tests.
I just found, that find&replace dialog has probably the same
problem (this was not visible before, because of another problem in
The previous problem with find&replace was:
I will work on this today.
Have patch, will commit tomorrow.
The global mouse listener was giving some rather misleading results
(1.3.1_01); working around this by explicitly checking root panes if
it is said that a dialog was entered. HelpAction.java 1.27
verified in [nb_release330](200112102331)
Resolved for 3.4.x or earlier, no new info since then -> closing.