This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 172702 - threading model of BreakpointsNodeModel
Summary: threading model of BreakpointsNodeModel
Status: RESOLVED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: Sun All
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-21 17:02 UTC by Vladimir Voskresensky
Modified: 2009-09-25 09:13 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Voskresensky 2009-09-21 17:02:51 UTC 
threading model of breakpoint enabling and disabling was changed in core, while was needed by JDPA part only. It's not
compatible change.

java.lang.AssertionError
    at com.sun.tools.debugger.dbxgui.debugger.dbx.CommonDbx.sendCommandHelp(CommonDbx.java:1101)
    at com.sun.tools.debugger.dbxgui.debugger.dbx.Dbx.sendCommandHelp(Dbx.java:251)
    at com.sun.tools.debugger.dbxgui.debugger.dbx.Dbx$1.run(Dbx.java:338)
    at com.sun.tools.debugger.dbxgui.debugger.dbx.Dbx.runCommandInt(Dbx.java:297)
    at com.sun.tools.debugger.dbxgui.debugger.dbx.Dbx.sendCommandInt(Dbx.java:336)
    at com.sun.tools.debugger.dbxgui.debugger.dbx.DbxDebuggerImpl.setHandlerEnabled(DbxDebuggerImpl.java:2724)
    at com.sun.tools.debugger.dbxgui.debugger.breakpoints.Handler.postEnable(Handler.java:156)
    at com.sun.tools.debugger.dbxgui.debugger.breakpoints.NativeBreakpoint.setPropEnabled(NativeBreakpoint.java:2291)
    at com.sun.tools.debugger.dbxgui.debugger.breakpoints.NativeBreakpoint.disable(NativeBreakpoint.java:275)
    at org.netbeans.modules.debugger.ui.models.BreakpointsNodeModel$BreakpointEnabler.run(BreakpointsNodeModel.java:223)
    at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:602)
    at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:1070)
Comment 1 Vladimir Voskresensky 2009-09-21 17:03:39 UTC 
needed for 6.8 (due to DBX integration)
Comment 2 Martin Entlicher 2009-09-22 21:46:21 UTC 
I've found that this was changed 4 years ago in http://hg.netbeans.org/main/rev/40ecec57ea31
Since there was also applied http://hg.netbeans.org/main/rev/30a6c502d456 two years ago, I guess we do not need the lazy
set of breakpoints enable/disable state in JPDA any more.

I'll make the call synchronous.
Comment 3 Martin Entlicher 2009-09-23 10:33:44 UTC 
Fixed in changeset:   146632:85ef0c74b02d
http://hg.netbeans.org/main/rev/85ef0c74b02d
Comment 4 Quality Engineering 2009-09-25 09:13:15 UTC 
Integrated into 'main-golden', will be available in build *200909241442* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/85ef0c74b02d
User: mentlicher@netbeans.org
Log: #172702 - Get rid of the lazy enable/disable of breakpoints since it's not necessary any more.