This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 168689 - installer and zip should have the same set of clusters
Summary: installer and zip should have the same set of clusters
Status: RESOLVED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: nbbuild-issues@ide
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-16 15:51 UTC by Ivan Sidorkin
Modified: 2009-07-27 16:39 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Sidorkin 2009-07-16 15:51:46 UTC
NetBeans IDE Build 200907160201


full installer has javacard1 cluster but full zip doesn't

installer and zip should have the same set of clusters
Comment 1 Marian Mirilovic 2009-07-16 16:00:31 UTC
Isn't that another symptom of our tests ?
Comment 2 Marian Mirilovic 2009-07-16 16:02:40 UTC
Michal/Robert, isn't that another symptom of running our tests right after build of IDE - before zipping the final zip?
Comment 3 Michal Zlamal 2009-07-17 13:12:06 UTC
The issue here is that Tim Boudreau created a new cluster without letting us kno
Comment 4 Michal Zlamal 2009-07-17 13:34:41 UTC
c6f2ed2c26e5 in be-main - There is no reason why javacard modules need to have its own cluster, those modules are UC only
Comment 5 _ tboudreau 2009-07-20 09:29:46 UTC
There is no guarantee that the javacard modules will not be added to the full build - in fact there is pressure from the
Java Card team and elsewhere to provide a build of NetBeans that includes them, or possibly include them in at least the
Windows version of the "big ide" build.

Whether to include them in the full build or not is a marketing decision, but it has looked likely that they will be in
some installer-based build of NetBeans.  They are UC-only for now because we did not get legal approval to open source
them in time for 6.7, not because the plan is for them to be UC-only.  That is why there is (was) a cluster.  


I would appreciate it if you would cc me on such an issue and ask me why I created the cluster, rather than just
deleting it - it was created for a reason.  There were plenty of people in Prague who knew to expect a javacard cluster.
 I am sorry you were not one of them, and that won't happen again, but please ask me before you do this sort of thing
next time.  

Or, preferably, revert c6f2ed2c26e5 and fix the whatever test does not like the cluster list being different from the
actual set of clusters.  There is no reason you should not be able to have a listed cluster which is missing - in fact
that is exactly how it is in any of the non-"big ide" builds.  

Really this issue should be closed as INVALID and the change reverted.  The javacard cluster was created as part of a
plan, not because I just happened to feel like it.
Comment 6 Quality Engineering 2009-07-20 09:47:32 UTC
Integrated into 'main-golden', will be available in build *200907200201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c6f2ed2c26e5
User: Michal Zlamal <mzlamal@netbeans.org>
Log: #168689 There is no reason why javacard modules need to have its own cluster, those modules ara UC only
Comment 7 Ivan Sidorkin 2009-07-20 10:21:31 UTC
Tim, it is absolutely VALID issue. Zip and installer should  have same set of clusters.

Michal, please mark it Fixed and I will verify it.

Tim, if you think javacard should be part of full installer - please file another issue.
We run auto tests using full zip, also some people use zip for testing, so to catch issues that can be introduced by
adding new cluster zip and installer should be the same.
Also, if you want to see javacard as part of full installer build please fix Issue 167698.
Comment 8 Jesse Glick 2009-07-21 23:36:44 UTC
c6f2ed2c26e5 was bogus, as can be seen from the golden files diff from that build; the javacard cluster disappeared from
cluster.properties but was still in build.properties, so the javacard modules do not get built by nbms-and-javadoc and
the moduleconfig list shows an unevaluated property.

Anyway just because modules are on UC does not mean they should not have their own cluster; stableuc and
daily-alpha-nbms contain various other special clusters, such as uml, visualweb, or python. Clearly the problem was not
in the regular build scripts (nothing in nbbuild/*.properties asks to include the javacard cluster in the standard
build), so some other fix is needed. Perhaps nbbuild/newbuild/pack-all-components.sh is incorrect?

I am backing c6f2ed2c26e5 out therefore: core-main c7ba886d8ea9
Comment 9 Jesse Glick 2009-07-22 14:56:46 UTC
nbms-and-javadoc #3575 contains the backout and shows that it was necessary:

-stableuc:${nb.cluster.javacard}
+stableuc:javacard.apdu.io
+stableuc:javacard.console
+stableuc:javacard.filemodels
+stableuc:javacard.kit
+stableuc:javacard.project
+stableuc:javacard.ri.bundle
[etc.]
Comment 10 Quality Engineering 2009-07-23 07:44:36 UTC
Integrated into 'main-golden', will be available in build *200907230201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c7ba886d8ea9
User: Jesse Glick <jglick@netbeans.org>
Log: Backed out changeset c6f2ed2c26e5
Improper fix of #168689 caused problems for nbms-and-javadoc (javacard cluster disappeared).
Comment 11 Jesse Glick 2009-07-23 21:53:15 UTC
Probably fixed by 59ad1394fbd4.
Comment 12 Michal Zlamal 2009-07-27 14:35:44 UTC
So does it mean that anybody can create any cluster without any notification?

AFAIK there a policy that all modules which are on UC should go to 'extra' cluster unless there is real reason why not.

The reason that it looks nicer and that there is a plan is not valid reason.
Comment 13 Jesse Glick 2009-07-27 16:39:56 UTC
Historically there have been several clusters not in the standard distribution. I don't know of any policy mandating use
of the 'extra' cluster; it is just the fallback if no specific cluster has been set.