This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 168480 - parseprojectxml does not skip non-jar-file classpath entry
Summary: parseprojectxml does not skip non-jar-file classpath entry
Status: RESOLVED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Harness (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker (vote)
Assignee: nbbuild-issues@ide
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-13 13:50 UTC by heithecker
Modified: 2009-07-14 06:25 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description heithecker 2009-07-13 13:50:49 UTC
When creating the public-packages-jar, the ant task org.netbeans.nbbuild.ParseProjectXml  (parseprojectxml) does not
skip classpath entries which are not actually paths to .jar-files. 

After logging the no existing classpath entry, it is NOT actually skipped and causes an io exception. 

See the following lines:
  1302                  if (!jar.isFile()) {

  1303                     log("Classpath entry " + jar + " does not exist; skipping", Project.MSG_WARN);

  1304                 }

Should there be a "continue" after line 1303?

An error is caused e.g. if in netbeans 6.7 in a netbeans rcp application an external cluster is included an the external
module jar has a Class-Path entriy in its manifest which refers to a directory an not to a jar-file.
Comment 1 Jesse Glick 2009-07-13 20:30:48 UTC
Yes, there should have been a continue statement. core-main #df465b08666e

Note that Class-Path entries which are directories are not supported for module JARs; in particular, the public package
JAR will still not be created correctly in this case: no classes from public packages in the directory (if there are
any) will be included.
Comment 2 Quality Engineering 2009-07-14 06:25:27 UTC
Integrated into 'main-golden', will be available in build *200907140201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/df465b08666e
User: Jesse Glick <jglick@netbeans.org>
Log: #168480: missing continue statement.