This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 167247 - platform sources zip contains files with licenses
Summary: platform sources zip contains files with licenses
Status: RESOLVED WORKSFORME
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: nbre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-17 15:42 UTC by Michal Zlamal
Modified: 2015-09-22 20:59 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Zlamal 2009-06-17 15:42:12 UTC
in nbbuild/licenses directory in source platform zip there are files which contains texts of many different licenses.

Only nbbuild/licenses/CDDL-GPL-2-CP is referenced in sources.

Other license files only confuse users and shouldn't be bundled.
Comment 1 Michal Zlamal 2009-06-17 16:20:56 UTC
Fixed in CS aa5cc1c6fb8a
Comment 2 Jesse Glick 2009-06-17 16:27:08 UTC
This dir is an essential part of the build process and should not be truncated.

Furthermore, it is not true that only CDDL-GPL-2-CP is relevant, even for the subset of sources contained in the
platform source ZIP. A quick look through apisupport.harness/external/ shows several other licenses being used by
third-party software.

Finally, the build process itself automatically creates nbbuild/netbeans/THIRDPARTYLICENSE-generated.txt according to
the actual set of modules built.
Comment 3 Michal Zlamal 2009-06-17 16:37:02 UTC
licenses for external binaries are in their external directory:
$ pwd
/work/be-main/apisupport.harness/external
$ ls -la
total 3840
drwxr-xr-x  17 michal  michal      578 Jun 17 16:21 .
drwxr-xr-x  14 michal  michal      476 Jun 17 17:28 ..
-rw-r--r--   1 michal  michal     1811 Jun  4 14:10 asm-2.2.1-license.txt
-rw-r--r--   1 michal  michal    34783 Jun 17 16:21 asm-2.2.1.jar
-rw-r--r--   1 michal  michal     1816 Jun  4 14:10 asm-tree-2.2.1-license.txt
-rw-r--r--   1 michal  michal    16274 Jun 17 16:21 asm-tree-2.2.1.jar
-rw-r--r--   1 michal  michal      419 Jun  4 14:10 binaries-list
-rw-r--r--   1 michal  michal     1145 Jun  4 14:10 cobertura-1.9-license.txt
-rw-r--r--   1 michal  michal   193907 Jun 17 16:21 cobertura-1.9.jar
-rw-r--r--   1 michal  michal     3118 Jun  4 14:10 jakarta-oro-2.0.8-license.txt
-rw-r--r--   1 michal  michal    65261 Jun 17 16:21 jakarta-oro-2.0.8.jar
-rw-r--r--   1 michal  michal    19512 Mar  3 14:26 jsearch-2.0_05-license.txt
-rw-r--r--   1 michal  michal   166255 Jun 17 16:21 jsearch-2.0_05.jar
-rw-r--r--   1 michal  michal     3040 Jun  4 14:10 log4j-1.2.9-license.txt
-rw-r--r--   1 michal  michal   352291 Jun 17 16:21 log4j-1.2.9.jar
-rw-r--r--   1 michal  michal    19551 Mar  3 14:26 openjdk-javac-6-b12-license.txt
-rw-r--r--   1 michal  michal  1058640 Jun 17 16:21 openjdk-javac-6-b12.jar

So there in no need to bundle them once more. Also platform builds without nbbuild/licenses directory.
Comment 4 Jesse Glick 2009-06-17 16:50:00 UTC
I think you misunderstand. */external/*-license.txt contain the original license texts as downloaded from the origin
project. nbbuild/licenses/* are generic normalized versions of licenses used to generate the master license file. The
algorithm is to collect all origin licenses associated with binaries copied into the build, validate that each matches
its generic version except in insignificant details, then append all the generic licenses in use together with a summary
of other details such as SHA-1 hash. Presence of a file in nbbuild/licenses/ does _not_ imply that this license is
associated with any binary in the current module build configuration.
Comment 5 Antonin Nebuzelsky 2009-06-18 09:56:41 UTC
> Presence of a file in nbbuild/licenses/ does _not_ imply that this license is
> associated with any binary in the current module build configuration.

That's understood by all of us here. Unfortunately it confuses our users who download platform source zip to have only
the platform. The users find the licenses directory in the zip and naturally assume that those licenses there are
related to the components of the platform they just downloaded.

This must be fixed somehow. Removing the license texts unrelated to platform from the platform zip is IMO the right
solution.
Comment 6 Jesse Glick 2009-06-18 17:11:00 UTC
nbbuild/licenses could have a README file explaining what it is for.

Anyway the current fix is wrong because it excludes non-CDDL+GPL licenses which are actually in use, such as for
JavaHelp or Cobertura.
Comment 7 Quality Engineering 2009-06-19 20:24:30 UTC
Integrated into 'main-golden', will be available in build *200906191401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/aa5cc1c6fb8a
User: Michal Zlamal <mzlamal@netbeans.org>
Log: #167247 Source platform zip shouldn't contain lincense files which are not used
Comment 8 Jesse Glick 2009-11-20 08:06:02 UTC
Remaining issues are not P1.
Comment 9 Marian Mirilovic 2010-09-23 08:34:04 UTC
We've been living with current state ages ... P3
Comment 10 pgebauer 2015-07-28 11:08:32 UTC
What are remaining issues?