This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 166635 - Templates/JSP_Servlet/javascript.shadow and Templates/JSP_Servlet/json.shadow are not valid DataShadows.
Summary: Templates/JSP_Servlet/javascript.shadow and Templates/JSP_Servlet/json.shadow...
Status: VERIFIED FIXED
Alias: None
Product: javascript
Classification: Unclassified
Component: Editor (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: Vitezslav Stejskal
URL:
Keywords: RANDOM, TEST
: 167050 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-06-05 20:04 UTC by Martin Entlicher
Modified: 2010-02-17 06:54 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Entlicher 2009-06-05 20:04:43 UTC
See
http://deadlock.netbeans.org/hudson/job/trunk/5964/testReport/org.netbeans.core.validation/ValidateLayerConsistencyTest/testValidShadows/

ruby.project/src/org/netbeans/modules/ruby/rubyproject/ui/resources/layer.xml defines:
 <file name="javascript.shadow">
                <attr name="originalFile" stringvalue="Templates/Other/javascript.js"/>
 ...
 <file name="json.shadow">
                <attr name="originalFile" stringvalue="Templates/Other/json.json"/>
 ...

The referenced templates are defined in javascript.editing/src/org/netbeans/modules/javascript/editing/layer.xml

Do you have dependency on javascript.editing? Are you sure that the templates should be referenced here?
Comment 1 Martin Entlicher 2009-06-05 20:12:29 UTC
I've found that this was actually caused by jglick's: http://hg.netbeans.org/main/rev/a051a7599f2d
Comment 2 Jesse Glick 2009-06-06 02:04:34 UTC
My change was months ago, something must have been broken since then.
Comment 3 Erno Mononen 2009-06-08 14:47:17 UTC
I'll have a look. In any case, the build job for ruby-main is passing (and so are other jobs), so seems that something 
in main broke this.
Comment 4 Erno Mononen 2009-06-10 12:37:45 UTC
I don't know what was causing this, but trunk seems to be back to stable for some time already. The same test never 
failed in ruby-main, and the shadows in rubyproject seem fine to me.
Comment 5 Erno Mononen 2009-06-11 07:42:24 UTC
Reopening as the test is failing again in trunk.
Comment 6 Erno Mononen 2009-06-11 07:57:11 UTC
I can't see anything wrong in ruby.rubyproject, as I wrote earlier the shadows seem fine to me and the test is failing  
in trunk only. Moreover it is failing seemingly randomly. Shouldn't be a dependency problem either as 
javascript.editing is in the IDE cluster. 

Reassigning to ide/commit validation for further evaluation.
Comment 7 Martin Entlicher 2009-06-17 16:03:09 UTC
Happens again:
http://deadlock.netbeans.org/hudson/job/trunk/6042/testReport/org.netbeans.core.validation/ValidateLayerConsistencyTest/testValidShadows/

And prevents from propagation of important fixes into daily build!

PLEASE FIX!
Comment 8 Jesse Glick 2009-06-17 17:52:52 UTC
#6043 passed, with no obviously related fix. Seems random? Key error is

org.netbeans.InvalidException: StandardModule:org.netbeans.modules.javascript.editing jarFile:
/hudson/workdir/jobs/trunk/workspace/nbbuild/netbeans/ide11/modules/org-netbeans-modules-javascript-editing.jar: Layer
not found: org/netbeans/modules/javascript/editing/layer.xml

I suspect some problem in javascript.editing/build.xml#jar (which uses <csljar>). The build log in #6042 shows

javascript.editing.jar:
Building jar:
/hudson/workdir/jobs/trunk/workspace/nbbuild/netbeans/ide11/modules/org-netbeans-modules-javascript-editing.jar
   Handling text/javascript
   Handling text/x-json
Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException: Null path encountered in [null] of type
JavascriptBootClassPath
        at org.netbeans.api.java.classpath.GlobalPathRegistry.register(GlobalPathRegistry.java:188)
        at org.netbeans.modules.javascript.editing.JsLanguage$1.run(JsLanguage.java:92)
        at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
        at java.awt.EventQueue.dispatchEvent(EventQueue.java:597)
        at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
        at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
        at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
        at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

Why javascript.editing module code is running during its own JAR creation, why this code is running on EQ, and why an
uncaught exception fails to halt the build - I don't know. javascript.editing module owner (vstejskal? mfukala?
jjancura?) please evaluate.
Comment 9 Vitezslav Stejskal 2009-06-18 12:39:57 UTC
"Why javascript.editing module code is running during its own JAR creation" - Decent men don't use language that would
be required to comment on this :-)

"why this code is running on EQ" - What is running in EQ is a task launched by JsLanguage constructor. JsLanguage is
instantiated from CslJar, see above.

"and why an uncaught exception fails to halt the build" - I only guess here, but most likely because it's thrown in the
AWT thread, which is not the one running ant tasks and performing the build.

Marek is on holiday, so I'll fix it somehow.
Comment 10 Vitezslav Stejskal 2009-06-18 13:11:20 UTC
This will hopefully fix it - http://hg.netbeans.org/jet-main/rev/ed4c37762f91
Comment 11 Quality Engineering 2009-06-19 07:47:42 UTC
Integrated into 'main-golden', will be available in build *200906190201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/ed4c37762f91
User: Vita Stejskal <vstejskal@netbeans.org>
Log: #166635 - do nothing when JsLanguage is instantiated from CslJar task during the build
Comment 12 Jan Jancura 2009-07-28 15:15:55 UTC
*** Issue 167050 has been marked as a duplicate of this issue. ***
Comment 13 Martin Schovanek 2010-02-17 06:54:31 UTC
v.