This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 166085 - Multiple lines in Variable Formatter are lost after IDE restart
Summary: Multiple lines in Variable Formatter are lost after IDE restart
Status: VERIFIED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Java (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-27 10:39 UTC by pribyl
Modified: 2009-05-29 12:05 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pribyl 2009-05-27 10:39:28 UTC
Product Version: NetBeans IDE 6.7 RC1 (Build 200905270001)
Java: 1.6.0_14-ea; Java HotSpot(TM) Client VM 14.0-b12
System: Windows XP version 5.1 running on x86; Cp1250; cs_CZ (nb)

User's code in variable formatter is lost after IDE restart (in case it has more than one line).

To reproduce:
1. In Options - Misc. - Java Debugger select Variable Formatters.
2. Add new Formatter (type Name and Class type), check 'Value formatted as a result of code snippet:'
3. Add custom code with more than 1 line 
4. Restart IDE

-> When you check your formatter now, only the first line of your code is present

Note: this issue was consulted with developer (Martin) - fix should not be a problem (hopefully) and can be integrated
into RC1 release.
Comment 1 Martin Entlicher 2009-05-27 11:22:37 UTC
There is missing translation of multi-line Strings when settings are saved into properties file. This is there from the
very beginning, but only now causes problems when we need to store multi-line Strings.
Comment 2 Martin Entlicher 2009-05-27 14:11:32 UTC
Fixed in trunk changeset:   133587:a84e7d4df68a
http://hg.netbeans.org/main/rev/a84e7d4df68a
Comment 3 Filip Zamboj 2009-05-27 16:18:17 UTC
will verify in trunk right after build is ready
Comment 4 Filip Zamboj 2009-05-27 16:19:12 UTC
I ment after I build it
Comment 5 Filip Zamboj 2009-05-27 16:45:34 UTC
can't build netbeans ... has to wait 

[nbmerge] Failed to build target: all-vmd.codegen
Comment 6 Jan Stola 2009-05-27 17:01:04 UTC
I have reviewed the fix and it is correct and safe. I found only one nitpick - there are missing NOI18N comments on 
lines with string literals.
Comment 7 Martin Entlicher 2009-05-27 17:08:02 UTC
NOI18N comments are almost nowhere, therefore it's not important for this fix.
Thanks for the review.
Comment 8 Filip Zamboj 2009-05-27 17:10:25 UTC
@mentlicher: please, send me jar today/tomorrow and I'll verify asap. 

thanks 
Comment 9 Quality Engineering 2009-05-28 08:43:19 UTC
Integrated into 'main-golden', will be available in build *200905280201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/a84e7d4df68a
User: mentlicher@netbeans.org
Log: #166085 - Convert multi-line values to single-line for correct read and write operations.
Comment 10 Filip Zamboj 2009-05-28 09:31:00 UTC
verified in netbeans-6.7rc1 with jar provided from martin. 

please backport to release 67 as soon as possible. 

Product Version: NetBeans IDE 6.7 RC1 (Build 200905270001)
Java: 1.6.0_13; Java HotSpot(TM) 64-Bit Server VM 11.3-b02

Comment 11 Filip Zamboj 2009-05-28 09:31:34 UTC
verified 
Comment 12 Martin Entlicher 2009-05-28 09:33:41 UTC
Should be left opened according to http://wiki.netbeans.org/NB67HighResistance, until it's integrated into release67.
Comment 13 Filip Zamboj 2009-05-28 09:41:05 UTC
sorry then :).
please, add changeset once you commit. thanks 
Comment 14 Martin Entlicher 2009-05-28 10:52:56 UTC
Pushed into release67 in changeset:   133360:1db64d188f3b
http://hg.netbeans.org/release67/rev/1db64d188f3b
Comment 15 Filip Zamboj 2009-05-29 12:05:51 UTC
verified in RC1 build 
2009-05-28_22-43-49