This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 165650 - SimplifiedJSPServlet unable to retrieve JSP parser result - java editing features in JSP don't work
Summary: SimplifiedJSPServlet unable to retrieve JSP parser result - java editing feat...
Status: VERIFIED WORKSFORME
Alias: None
Product: javaee
Classification: Unclassified
Component: JSP (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: Marek Fukala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-20 20:22 UTC by Tomasz Slota
Modified: 2009-05-21 09:40 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Slota 2009-05-20 20:22:27 UTC 
I was going to finish working on issue 157782. I've refreshed sources and made a new build, since then creating the simplified servlet is completely broken 
- see the fragment of code below:

 //Workaround of issue #120195 - Deadlock in jspparser while reformatting JSP
 //Needs to be removed after properly fixing the issue
 if (!DocumentUtilities.isWriteLocked(doc)) {
       JspParserAPI.ParseResult parseResult = JspUtils.getCachedParseResult(fobj, false, false);
       if (parseResult == null || !parseResult.isParsingSuccess()) {
         processingSuccessful = false;
         return; // THIS ALWAYS HAPPENS!
      }
 }
Comment 1 Tomasz Slota 2009-05-20 20:27:45 UTC 
obviously I've tried it on a clean user dir
Comment 2 Marek Fukala 2009-05-21 07:14:46 UTC 
I'll look at it.
Comment 3 Marek Fukala 2009-05-21 08:03:11 UTC 
According to offline talk to Tomasz no java features should work in JSP.

I built IDE from fresh sources before a moment and run with new userdir and everything works perfectly. All java
features like semantic coloring and completion works nice. 

Also processing of the included files works nice - I tried to declare a variable in a scriptlet in an included file and
it is visible in the java completion in the including file. The same for declared beans, works nice also via included files.

Nice work Tomasz, closing as worksforme. I guess there's an error in your project or one of the files which make it
unparsable.

Just for sure I am kindly asking Jindra Sedek to verify it asap. Thanks Jindro.
Comment 4 Jindrich Sedek 2009-05-21 08:41:38 UTC 
I see no problems with java fetaures in JSPs, just an a beans included from other file is marked as an error on first 
line in editor, but it's probably the reason, why issue 157782 is still open.
Comment 5 Tomasz Slota 2009-05-21 09:40:41 UTC 
I refreshed  sources, made a new build and the problem is gone. Thanks for looking at it. I will definitely need to write tests for the simplified servlet stuff.