This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 165461 - I18N: "Nodes" is not from bundle
Summary: I18N: "Nodes" is not from bundle
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Outline&TreeTable (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jiri Rechtacek
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2009-05-19 07:53 UTC by Masaki Katakai
Modified: 2009-05-22 09:11 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot, brownsing subversion repositories for checkout (85.08 KB, image/png)
2009-05-19 13:36 UTC, Masaki Katakai
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2009-05-19 07:53:06 UTC
It seems that "Nodes" is hardcoded so it can not be localized.

o.n.swing.outline/src/org/netbeans/swing/outline/DefaultOutlineModel.java:
    private String nodesColumnLabel = "Nodes";
Comment 1 Jiri Rechtacek 2009-05-19 12:41:11 UTC
IMHO, this is not a real I18N bug. o.n.swing.outline library is just a Java Swing extension of JTable, it has no
relation with NetBeans Platform infrastructure like NbBundle. AFAIK, all clients this o.n.swing.outline component IDE
provide own label (fully internationalized) and this "Nodes" string is just a fallback if no other label is set. Reopen
if this non-internationalized is appearing somewhere in IDE but I guess there is none. Thanks
Comment 2 Masaki Katakai 2009-05-19 13:33:58 UTC
Thank you Jiri for the evaluation.

I filed this issue because I'm seeing un-localized "Nodes" in several places
of actual UIs, at least,

- subversion/src/org/netbeans/modules/subversion/ui/browser/BrowserPanel.java
- subversion/src/org/netbeans/modules/subversion/ui/history/DiffTreeTable.java
- apisupport.project/src/org/netbeans/modules/apisupport/project/ui/customizer/SuiteCustomizerLibraries.java(?)
- mercurial/src/org/netbeans/modules/mercurial/ui/log/DiffTreeTable.java
- subversion/src/org/netbeans/modules/subversion/ui/browser/BrowserPanel.java
Comment 3 Masaki Katakai 2009-05-19 13:36:27 UTC
Created attachment 82388 [details]
screenshot, brownsing subversion repositories for checkout
Comment 4 Masaki Katakai 2009-05-20 12:33:24 UTC
Jiri, could you evaluate?
Comment 5 Jiri Rechtacek 2009-05-21 09:26:17 UTC
Okay, I'll care about them.
Comment 6 Jiri Rechtacek 2009-05-21 12:47:06 UTC
fixed in core-main/rev/7a2ee76a7e4d
Thanks Masaki, due to this issue I can found out a hidden regression in setting name of the 0st column in OutlineView
(core-main/rev/11d25ef69401)
Comment 7 Quality Engineering 2009-05-22 07:28:21 UTC
Integrated into 'main-golden', will be available in build *200905220201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/7a2ee76a7e4d
User: Jiri Rechtacek <jrechtacek@netbeans.org>
Log: #165461: I18N: "Nodes" is not from bundle
Comment 8 Masaki Katakai 2009-05-22 09:11:01 UTC
Thank you very much Jiri!

Oh, now I understand what you're saying. On 200905220201 build,
the 1st column is displaying the correct label, not fallback's "Nodes".
Anyway, it's great that we fixed before code freeze :-)