I have set the Help Id of a Property Sheet, ie:
Sheet.Set s = new Sheet.Set ();
s.setValue ("helpID", "my_help_tag");
Using FFJ 3.0 (based on NB3.2), if I displayed
this tab on the property sheet, hit F1, the help
was displayed in the help viewer. Using new
builds of FFJ based on NB3.3, this no longer works.
Please, a question:
Does it display no Help window or wrong page for your ID specified?
On my machine the F1 works (Linux), on last builds (NB and FFJ as well).
I found out you are right and ment that always the default help page
was showed, instead of the one you specified by help ID. The regressio
was caused by refactoring of prop sheets about 2 months ago.
Fixed in [main-trunk].
verified in [nb_dev](20011112)
Now if you have selected some property which has setvalue, after
hitting F1 Help window with right help arise.
But there is another issue with additional problem issue 17424.
Sorry, it is not working for me. Maybe it was fixed, but it is not working now, in the
trunk at least (early March sources). Lower priority since no one really used
property-level help so I do not think it is critical even though it is a regression,
but it would be nice to fix for 3.4.
See unit tests in issue #14701. (Not committed to CVS yet but you can run them, see
attachments there.) Also see interactive test class in #20794 which makes the problem
easy to see.
Node.PropertySet help works fine. But Node.Property help does not work at all. Setting
an ID on the N.P has no effect; the property sheet continues to look for an ID on the
active N.PS and then on the containing Node. Examining the
org.openide.explorer.propertysheet.* code, I can see nothing which even looks for an ID
on a N.P (the code which finds it on a N.PS looks straightforward).
Please reexamine this. If fixed properly, the config-file exclude in #14701 should not
be necessary - all the help tests ought to pass. The unit tests should make it easier
for propsheet developers to make sure it does not get rebroken.
#14701 tests are in CVS now. Please try removing the exclude of the
second property sheet help test. If this is fixed, the test should be
included in the stable test suite again.
Passing to new owner.
the FindHelpTest was included in stable suite.
Jirka I found three problems with your patch to cfg-unit.xml:
1. The sequence
is redundant, the second line does nothing.
2. FindHelpTest is supposed to be run with the code executor, not the
ide executor. Please change
to indicate that *both* tests in this class should be run.
3. You did not remove this test from the failing config:
<!-- Implementation was apparently killed during a
Are you sure this problem is now fixed (you verified it manually using
the supplied demo class from issue #20794, as well as running the unit
test)? I did not see any code changes which were supposed to fix the
bug, and a search of org.openide.explorer.propertysheet.* sources
still reveals only one use of "helpID" in PropertySheetTab, getting
help on the tab but not an individual property.
Created attachment 5314 [details]
Patch to fix cfg file to include all help tests, in case #16430 is fixed
more investigate on FindHelpTest, test failed on
setting test bags will be edited right
Jesse, you are right, I overlooked there were two FindHelpTest in
explorer and else in explorer/propertysheet directory at first and I
included the explorer/propertysheet/FindHelpTest twice at second and
FindHelpTest/testFindHelpOnPropertySheetRow() didn't work at last. I'm
going to set the unit tests back for now. Sorry for annoyance.
the propertysheet/FindHelpTest excluded again from statble testbag_2,
it has failed yet.
Set target milestone to TBD
I move this one to property sheet subcomponent, but maybe Jirka could
finish his work :)
IMHO this is now P4 - help on the tab works, just not help on rows,
and no one that I am aware of is using help on individual rows.
reassign to Tim as propertysheet owner, note:
propertysheet/FindHelpTest fails constantly (was tried on Feb 19 dev)
Adding to property sheet umbrella issue
Fixed - new property sheet committed.
Note code in findHelpTest temporarily commented out - needs
a rewrite to deal with the new components.
verified in [nb_dev](20030718)