This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 16351 - Cannot set mnemonics for menu items in Mount-> Version Control
Summary: Cannot set mnemonics for menu items in Mount-> Version Control
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: All All
: P4 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: A11Y
Depends on:
Blocks:
 
Reported: 2001-10-08 18:43 UTC by Sophie Deng
Modified: 2003-07-01 12:56 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sophie Deng 2001-10-08 18:43:26 UTC
My filesystem subclass vcscore.VCSFilesystem, and registers itself under
Templates/Mount/VCS via the module layer. After these steps, my module
mountwizard can be accessed from Versioning -> Mount Version Control-> My
Version Control System. How do I set the mnemonic for it?


Discussions on nbdev --
> Gabriel Tichy wrote:
>  Jaroslav Tulach wrote:
>  > Martin Entlicher wrote:
>  > 
>  > > There is no support for mnemonics I know of. There are no mnemonics for
other
>  > > filesystems as well (in Filesystems -> Mount). Does anyone from UI/HIE
know 
if
>  > > this is being planned?
>  > > Probably the API for XML filesystem would have to be extended to
interpret
>  > > something like Templates/Mount/VCS_Mnemonic=V in
>  > > SystemFileSystem.localizingBundle.
>  > 
>  > Does not Templates/Mount/VCS=&VCS work? It could.
>  > y.
>  AFAIK, it doesn't.
>  
>  Gabo
>  
>  
Just tried. No, it doesn't work.


Sophie
Comment 1 dpavlica 2001-10-31 19:59:53 UTC
...
Comment 2 Jiri Mzourek 2001-11-19 16:57:18 UTC
CVS folks, could we do anything with that?
Comment 3 Martin Entlicher 2001-11-20 11:35:53 UTC
In Filesystems -> Mount there are no mnemonics either.
Versioning -> Mount VCS provides the *same* functionality.
It should be fixed in openide/core first, otherwise it would not be
consistent.
Therefore moving to core.

BTW: why can't you just use arrows? It's quite natural and simple.
Comment 4 Jan Zajicek 2001-11-21 09:18:50 UTC
Just updating version.
Comment 5 _ ttran 2001-11-22 15:17:50 UTC
as Martin Entlicher indicated this is "by design".  No way to fix it
for NB 3.3 because the fix would require API changes.  Too late to do
it now.  Decreased prio to P4 because the user can use arrow keys,
then enter to choose the menuitem
Comment 6 Peter Zavadsky 2001-11-29 10:15:25 UTC
Reassigned to vcscore.

Reasons:
I think the problem is there. VcsMountFromTemplate action uses as menu
presenter MenuView.Menu which is wrong. MenuView class was designed
for use in popup only (see javadoc), i.e. primarully in Explorer only
(therefore it resides in package explorer only), is designed to work
with nodes. Showing just nodes displayNames, not dealing with mnemonics.

So there soudn't be any redesign made to MenuView, but to
VcsMountFromTemplateAction.
Vcscore module should use another presenter for menu, not MenuView. I
guess the creation of the artificial node hierarchy representing the
vcs template folder thus making it for MenuView to fit is harmless.
Comment 7 Martin Entlicher 2001-11-29 10:54:19 UTC
Well, I can think of some fix to vcscore, but it will not fix the
problem on a general base.
The request for it to be fixed in core is still valid.
Comment 8 Martin Entlicher 2001-11-29 14:06:29 UTC
I'll do a fix specific to VcsMountFromTemplateAction, so that the
mnemonics will appear only on the menu, not on the popup.

Comment 9 Martin Entlicher 2001-11-29 14:17:22 UTC
Fixed in the main trunk and release33 branch.

Attribute VcsMountAction.mnemonic introduced. The value should be a
resource bundle (similar to SystemFileSystem.localizingBundle).
The value in the resource bundle should be <name-of-the-fileobject>_m

(You may see
vcscore/src/org/netbeans/modules/vcscore/resources/mf-layer.xml)
Comment 10 Jiri Kovalsky 2001-12-05 13:04:42 UTC
Fine, verified in development build #200112050331 of NetBeans 3.3.1.
Comment 11 Quality Engineering 2003-07-01 12:56:47 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.