This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
[#200904192254-6.7-beta, jdk1.5.0] to reproduce: ------------- 1) create a .js like (| represents the cursor): function ffff() {|} 2) open Tasks window and enable JS in the Default filter 3) type . (it introduce a error) 4) save the file ERROR: the Tasks list is not refreshed till you edit the filter
Reproducible.
*** Issue 163126 has been marked as a duplicate of this issue. ***
This is a generic CSL problem, the hints are refreshed only if the PushTaskScanner.setScope() is called which you can do in the tasklist UI. In java it works the way that the hints update is triggered by the RepositoryUpdater, resp. java indexer through TaskCache class. I am not sure if it ever worked in GSF (some of the method copied from JavaTaskScanner still exist) or just un/indentionally disabled during the CSL migration. Reassigniong to Vita since he is the most experienced person here.
Umm, when looking at 'Show tasks for all opened projects' the error in the jhavascript file never shows up, but when looking at 'Show tasks for currently edited file' the error shows up after manually refreshing the list. So, I assume this is the problem you are referring to - the necessity to manually refresh the task list.
Yep, switching the views triggers PushTaskScanner.setScope() which updates the tasks.
if you plan to fix this for NB 6.7 please rise the priority
We just discussed with Marek, this is a regression since 6.5. Moreover, this issue apparently affects all CSL-based languages (HTML, CSS, Ruby, PHP, ...). Martine, what's your opinion, is this a 6.7 stopper?
Yes, please fix it for 6.7.
Just found out that Groovy is affected too.
It is regression against 6.5 where Task list displays tasks from all .js files. See the attached image.
Created attachment 82992 [details] Nb 6.5 Tasklist for .js files
Ok, this issue is considered as a stopper for RC2/FCS. Proceed with bugfix into release67 ASAP, thanks in advance.
fixed in http://hg.netbeans.org/jet-main/rev/09dc12b5d333
Ok Hanz - thanks for the fix. Martin is waiting for a build where we'll test it. Keep it opened until fixed into release67. Thanks in advance.
I can see several problems with the patch: vs1: When calling QuerySupport.forRoots you should pass null as a value for the sourceIds parameter, because you are interested for all source roots and not just ClassPath.SOURCE, which denotes java source roots. vs2: The id and version of TLIndexerFactory should be static fields rather than adhoc constants scattered around the sources. vs3: Implement TLIF.filesDeleted() and TLIF.filesDirty() accordingly. It should be enough to just pass the indexable to the similar methods in IndexingSupport. vs4: Why are you calling SupportAccessor.getInstance ().store (indexingSupport); directly? You are not supposed to do this. Otherwise it looks ok. I haven't tested the code.
I found that this is not only a problem with JavaScript, but also with TODO tasks. I filed a separate issue 166858.
The second patch look better. The only problems I've found are in embeddings: the following xhtml fragment does not show todo for css and javascript in tasklist <head> <meta http-equiv="Content-Type" content="text/html; charset=windows-1250"/> <title>TODO supply a title</title> <style type="text/css"> div { /* TODO css todo */ } </style> <script type="text/javasctipt"> function aaaa() { } // TODO js todo </script> </head> also error and todo in inline css are not recognized, but the errors are not highlighted as well so I'm not sure it it should work. <p style="margin:auto; /* TODO inline*/"></p> For separate files all works fine (tested with html, xhtml, php, java, js)
Integrated into 'main-golden', will be available in build *200906110201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/09dc12b5d333 User: Jan Jancura <jjancura@netbeans.org> Log: #163125: JavaScript task list is not refreshed
Jirko, you are right the TODO tasks don't work well in these cases. However, this does not work for me even before Hanz's patch. So shouldn't this be filed as a separate issue? (Also, I believe this needs to be fixed on Standa's side.) BTW, the second patch is this one, right? http://hg.netbeans.org/jet-main/rev/f7f37c37265e
Integrated into 'main-golden', will be available in build *200906111401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/f7f37c37265e User: Jan Jancura <jjancura@netbeans.org> Log: #163125: JavaScript task list is not refreshed2
Integrated into 'main-golden', will be available in build *200906120201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/9dfec1c435aa User: Jan Jancura <jjancura@netbeans.org> Log: #163125: JavaScript task list is not refreshed3
http://hg.netbeans.org/release67/rev/00df246b6160 http://hg.netbeans.org/release67/rev/6c0def980d25 http://hg.netbeans.org/release67/rev/1dbeac06dbdb http://hg.netbeans.org/release67/rev/c83f917ab12c http://hg.netbeans.org/release67/rev/606e383b1b17
VERIFIED IN 6.7RC3