This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 162686 - [editor] Inactive "Save All" icon
Summary: [editor] Inactive "Save All" icon
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Data Systems (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jiri Rechtacek
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2009-04-15 10:24 UTC by dakala
Modified: 2009-06-05 15:59 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
messages.log (32.72 KB, text/plain)
2009-04-23 13:13 UTC, Jiri Rechtacek
Details
To prove the bug is really in platform (3.93 KB, patch)
2009-04-23 16:44 UTC, Jaroslav Tulach
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dakala 2009-04-15 10:24:34 UTC
Apologies if this has been reported but I couldn't trace any related issues.

The "Save All" icon remains inactive even when a file has been edited. The file name on the tab above the editor window
displays a star when the file contents have chnaged, which is the expected behaviour.

I'm using the 200904131401 build.
Comment 1 Ivan Sidorkin 2009-04-20 17:22:30 UTC
regression
affected all modules (java,php,cnd....)
Comment 2 Antonin Nebuzelsky 2009-04-21 09:16:41 UTC
Confirming in a trunk build 200904180201, but not able to reproduce in a Beta build 200904192254.

Also, when reproduced, Save action still works.

Can QA still reproduce the problem in Beta?
Comment 3 Antonin Nebuzelsky 2009-04-21 09:35:32 UTC
> Confirming in a trunk build 200904180201, but not able to reproduce in a Beta build 200904192254.

Actually after restart of the trunk build, the bug is not visible anymore. And in Beta it is reproducible as well,
confirmed by jrechtacek.

Because Save action works at the moment Save All action does not and restart makes Save All work as well, decreasing to P2.
Comment 4 Jiri Rechtacek 2009-04-21 11:18:51 UTC
Evaluated. 100% reproducible with 
1) fresh userdir
2) open some project created previously e.g.CustomerDB 
(btw. mostly it made IDE frozen - P1 issue 163201)
3) open some Java class
4) make a modification but openide.loaders/SaveAllAction is still disabled.
Restart IDE fix such problem.


I guess a weak listener is DataObject.getRegistry() is garbaged and then doesn't listens on changes anymore.
openide.loaders/SaveAllAction contains such code:
        DataObject.getRegistry().addChangeListener(
            (org.openide.util.WeakListeners.change(chl, DataObject.getRegistry())));
thus no ChangeEvents come into openide.loaders/SaveAllAction.ModifiedListL
Comment 5 Jiri Rechtacek 2009-04-21 11:19:43 UTC
Just a note: this problem w/o egronomics1 is not reproducible anymore.
Comment 6 Jaroslav Tulach 2009-04-22 13:33:50 UTC
I am not able to reproduce, but I've added logging into: core-main#6073ef041eb6
Start with -J-Dorg.openide.loaders.DataObject.Registry.level=100 to get more details about the problem. Reassigning to 
Jirka as the regular owner of platform/actions and also one who claims to be able to reproduce problem.
Comment 7 Quality Engineering 2009-04-23 08:59:44 UTC
Integrated into 'main-golden', will be available in build *200904230201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/6073ef041eb6
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #162686: Adding more logging, use with -J-Dorg.openide.loaders.DataObject.Registry.level=100
Comment 8 Jiri Rechtacek 2009-04-23 13:12:50 UTC
The bug confirmed in Dev IDE Build 090423, run with a verbose logging. Reproducible only if and only if ergonomics is
on. Don't blame platform with such bug, it should be tracked in ide/ergonomics responsibility.
Comment 9 Jiri Rechtacek 2009-04-23 13:13:49 UTC
Created attachment 80754 [details]
messages.log
Comment 10 Jiri Rechtacek 2009-04-23 13:20:32 UTC
Just a my point of view: I recalled why was in NetBeans6.0 decided to force IDE restart for deactivation of any plugin
in Plugin Manager. The reason was that NetBeans code is too buggy to fix all possible problem appearing while
deactivating plugin on-the-fly, we didn't want to assign too much resources (man days) to fix it all and made NetBeans
perfect in that operation. It guess it is the same reason why FeatureOnDemand/Ergonomics is beyond out ability to fix
all known and unknown problems. Just my 2cnt
Comment 11 Jaroslav Tulach 2009-04-23 16:44:03 UTC
Created attachment 80786 [details]
To prove the bug is really in platform
Comment 12 Jaroslav Tulach 2009-04-23 16:46:54 UTC
Jiří, if you are ready to accept the fact that the bug is in the SaveAllAction class itself now, please stop by and we 
can together seek revelation and proper fix.
Comment 13 Jiri Rechtacek 2009-05-06 11:09:06 UTC
core-main/rev/f2136c78b8fc
Comment 14 Quality Engineering 2009-05-07 07:56:12 UTC
Integrated into 'main-golden', will be available in build *200905070201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/f2136c78b8fc
User: Jiri Rechtacek <jrechtacek@netbeans.org>
Log: #162686: [editor] Inactive "Save All" icon
Comment 15 Marian Mirilovic 2009-06-05 15:59:31 UTC
comment from Deji Akala:
I've just done a clean install of 200904231401 build and the problem's
gone worse! The Save All icon, The Save, Save All and Save as ... menu
items remain greyed out when editing a file. The only indication  of
file change remains the star in front of the file name on the tab.