This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 162231 - [cat67][versioncontrol]Commit All toolbar button in subversion panel takes multiple clicks
Summary: [cat67][versioncontrol]Commit All toolbar button in subversion panel takes mu...
Status: NEW
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Subversion (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-08 15:15 UTC by dancehands
Modified: 2009-04-22 17:26 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dancehands 2009-04-08 15:15:34 UTC
I'm working with PHP projects and have noticed over the last week or possibly even two that the nightly builds have, I
think, introduced a bug where you have to click multiple times on the "Commit All" toolbar button in the Subversion
panel window before it will actually bring up the Commit dialog.

Steps to reproduce:

1) Open a PHP project that is already under Subversion control
2) right-click on a file in the Projects panel that you know you've changed and select "Subversion -> Show Changes"
3) In the Subversion panel now click the last icon in the toolbar on the right for "Commit All". You'll have to click it
at least 2 times before the Commit dialog will open.
Comment 1 Ondrej Vrabec 2009-04-08 16:21:16 UTC
When you are clicking the button, is the file's status already shown in the Subversion view? I mean:
1) a row is displayed saying: "File xyz with status 'Locally modified'"
2) THEN you click the button?
The reason i am asking is: most actions (including the commit action) are context-aware and work with currently cached
statuses of files in the context. If your file has not been cached yet (it is not shown in the Subversion view with
status 'Locally modified') the action will abort and do nothing.

So could you wait a little before pushing the button (push it after the row appears in the panel).
Comment 2 dancehands 2009-04-08 19:07:43 UTC
Yes, I did definitely wait until the list of files had all of the statuses updated before I tried clicking the Commit
All toolbar button. In fact, I even tried waiting 10-15 seconds AFTER the statuses had all been updated and the
statusbar indicator that a process was working had completed. Sorry I forgot to mention that in the first message. :)

FYI, now I'm seeing that *sometimes* it will work fine when clicking the Commit All button, and sometimes I have to
click it multiple times. I haven't been able to isolate what scenarios require the double-click and which don't. If I
can find a pattern I'll definitely post it here.
Comment 3 Ondrej Vrabec 2009-04-09 07:45:52 UTC
I meant no offense by my questions, it's just i don't see any other reason why the button shouldn't react.
Would it be possible if I sent you a modified module .jar with some extra logging and you then sent me the message.log?
Please specify your build number so i could e-mail you a compatible jar.
thanks
Comment 4 dancehands 2009-04-13 15:51:57 UTC
ovrabec,

No offense taken. I didn't intend to sound like I'd taken offense or to be short. ;)

Sorry for the delayed response, I was out of town for most of last week through the weekend. I've just downloaded the
latest build today 04.13.09 and I'll you know if I still experience the same issue. If you want to send me a custom .jar
file for debugging purposes that would be fine. I've not swapped out .jar files before so if that process is different
that simply replacing and existing .jar file let me know and I'll be happy to do whatever it takes to help figure this
one out.
Comment 5 dancehands 2009-04-16 22:53:38 UTC
ovrabec,

I may have found out the cause of this. It appears if the focus is on a tree node in the Projects pane and I hit the
keyboard shortcut to bring up the Show Changes dialog, then the focus is still on the tree node in the Projects page and
the first click on the "commit all" tooblar button puts the focus onto the Subversion panel. The second click then
triggers the actual Commit All action.

I hope this helps. :)
Comment 6 Ondrej Vrabec 2009-04-22 16:46:14 UTC
Hi,
I am still unable to reproduce. I will send you patched jar with some extra logging.

More questions: other buttons in the view work fine (update, refresh, etc.)?
What laf (Nimbus, GTK) are you using? And operating system?
Comment 7 dancehands 2009-04-22 17:26:50 UTC
@ovrabec,

Yes, the other buttons seem to work fine, although I use them MUCH, MUCH less so I'm probably less likely to notice if
they also require the double-click (once to put focus on the panel and second time to get the button click event to fire).

I'm not sure what laf is...sorry. But here is the OS info from the NB about window:

Product Version: NetBeans IDE Dev (Build 200904220201)
Java: 1.6.0_13; Java HotSpot(TM) Client VM 11.3-b02
System: Windows XP version 5.1 running on x86; Cp1252; en_US (nb)

I'd also recommend making this SUPER LOW priority since it really isn't all that bad if sometimes I have to double-click
to get the button to work. I changed the priority to P4 - but feel free to change as you see fit.

Thanks!