This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 162159 - [67cat] Output window does not respect 'Show Always Output' anymore
Summary: [67cat] Output window does not respect 'Show Always Output' anymore
Status: VERIFIED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Ant (show other bugs)
Version: 6.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: REGRESSION
Depends on: 184448
Blocks: 87801 167386
  Show dependency tree
 
Reported: 2009-04-07 18:04 UTC by Michel Graciano
Modified: 2010-04-29 15:22 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michel Graciano 2009-04-07 18:04:58 UTC
[ JDK VERSION : 1.6.* ]

Even this option is unselected, the output windows is always shown
when I run an ant task.
Comment 1 Stanislav Aubrecht 2009-04-08 08:18:59 UTC
not really sure who's to blame here - pls feel free to reassign
Comment 2 Michel Graciano 2009-04-14 13:41:39 UTC
According to guidelines[1], any regression is an P1.

[1]http://wiki.netbeans.org/BugPriorityGuidelines
Comment 3 t_h 2009-04-14 13:44:12 UTC
This is minor issue, not regression in functionality. Does this issue prevent you to do something?
Comment 4 Michel Graciano 2009-04-14 14:39:50 UTC
No, in this point you are right, this is just annoying since I use really huge Output views...

Regards
Comment 5 Michel Graciano 2009-04-14 14:42:32 UTC
Could you just say me which project it is? I will try to create a patch if possible.

Regards
Comment 6 t_h 2009-04-16 12:52:56 UTC
core-main #ca3d1b5648ab
Comment 7 Quality Engineering 2009-04-17 08:41:02 UTC
Integrated into 'main-golden', will be available in build *200904170201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/ca3d1b5648ab
User: Tomas Holy <t_h@netbeans.org>
Log: #162159: Output window does not respect 'Always Show Output' anymore
Comment 8 Michel Graciano 2009-04-22 14:44:37 UTC
v. 200904220201
Comment 9 dkkopp 2010-02-12 10:14:34 UTC
I am still seeing this bug in NetBeans IDE 6.8 (Build 200912041610) on both OS X and Windows Vista.

Windows Vista Java: 1.6.0_18; Java HotSpot(TM) Client VM 16.0-b13
OS X Java: Latest Mac update (1.6.0_17, I believe)

I am also finding this to be very annoying
Comment 10 Michel Graciano 2010-02-12 11:05:26 UTC
Could you send us steps to reproduce? I can help to try to fix this.
Comment 11 dkkopp 2010-02-12 11:57:49 UTC
I don't have to do anything special. I just created a new Java application, made sure the Always Show Output box is unchecked, hit F11 to build the application, and the output window opens.
Comment 12 Michel Graciano 2010-02-12 12:22:55 UTC
Yes, you are right, it is back :(
I will try to take a look at this next week.
Comment 13 dkkopp 2010-02-12 12:36:20 UTC
Thanks.
Comment 14 dkkopp 2010-02-16 17:02:18 UTC
Take a look at line 463 in TargetExecutor.java

The defined interestingOutputCallback is being passed into the ant executor, which ends up calling it through the logging framework. I think code needs to be added to the ant event logging to determine if the given event is "interesting" or not.
Comment 15 Michel Graciano 2010-02-17 03:49:06 UTC
Yes, I saw that. It is to be called when an input field is available. I have seen Jesse, the change author, is already looking this. Hopefully we will have an fix soon :)
Comment 16 Michel Graciano 2010-03-15 19:13:31 UTC
Well, the problem was already identified by dkkopp and confirmed by me but should be defined yet how to fix it. Maybe some NetFIXer [1] could take a look at this?

[1] http://wiki.netbeans.org/NetFIX
Comment 17 Jiri Kovalsky 2010-03-16 19:31:34 UTC
Yes, Jesse agreed to review & integrate possible bug fix from NetFIX team.
Comment 18 vezzoni 2010-03-30 18:47:11 UTC
Hi, I'd like to submit a patch but I'm not sure about it because I don't know the whole NetBeans API, so I am afraid about collateral damages.

For that reason, I'd like some community help.

On the Ant Module [1] within org.apache.tools.ant.module.bridge.impl.NbBuildLogger class at #768 line - InputOutput getIO() method.

before:

    public InputOutput getIO() {
        interestingOutputCallback.run();
        return io;
    }

after:

    public InputOutput getIO() {

        if (AntSettings.getAlwaysShowOutput()) {
            interestingOutputCallback.run();
        }

        return io;
    }

[1] ~/main-silver/o.apache.tools.ant.module
Comment 19 Jesse Glick 2010-03-31 23:19:39 UTC
Regression from bug #167386. Also t_h's original fix was not correct since it was intentional that Always Show Output be disabled by default (see bug #87801 for background).

Fix is not perfect since it introduces a minor regression: a hyperlink (StandardLogger.PartiallyLinkedLine.println) will no longer show the output window. Not solvable without an API extension to AntSession to show output, since getIO no longer does so, and println in this case is called with a null listener.
Comment 20 Jesse Glick 2010-03-31 23:30:37 UTC
core-main #66582d893086
Comment 21 Quality Engineering 2010-04-02 05:18:08 UTC
Integrated into 'main-golden', will be available in build *201004020200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/66582d893086
User: Jesse Glick <jglick@netbeans.org>
Log: #162159: [67cat] Output window does not respect 'Show Always Output' anymore
Comment 22 Jiri Kovalsky 2010-04-02 10:23:03 UTC
OK, I have removed this issue from NetFIX Pool. Thanks for your patch attempt Roberto anyway!
Comment 23 Michel Graciano 2010-04-05 18:24:12 UTC
Well, it is working again at least for me :)
Thanks everyone for the fix.
v. 100405-ba96ec22818f