This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 160076 - C/V test failed.
Summary: C/V test failed.
Status: VERIFIED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: WSDL Tools (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: Shivanand Kini
URL: http://deadlock.netbeans.org/hudson/j...
Keywords: TEST
Depends on:
Blocks:
 
Reported: 2009-03-11 10:12 UTC by Ivan Sidorkin
Modified: 2009-04-15 17:10 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Sidorkin 2009-03-11 10:12:17 UTC 
Error Message

Failed generate for org.netbeans.modules.xml.wsdlui in version 1.4
Comment 1 Ivan Sidorkin 2009-03-11 10:17:36 UTC 
sorry, wrong component
Comment 2 Shivanand Kini 2009-03-11 19:23:20 UTC 
Hi Ivan,
Can you explain what this test does and the test failure means?
Comment 3 Ivan Sidorkin 2009-03-11 20:06:19 UTC 
Jaroslav, Jesse, could you please answer.
Comment 4 Jesse Glick 2009-03-11 20:16:29 UTC 
Hidden class found: org.netbeans.modules.xml.wsdl.ui.wizard.WsdlPanel in constructor public
org.netbeans.modules.xml.wsdl.ui.wizard.WizardNewWSDLStep.WizardNewWSDLStep(org.openide.WizardDescriptor$Panel,org.netbeans.modules.xml.wsdl.ui.wizard.WsdlPanel)
in class org.netbeans.modules.xml.wsdl.ui.wizard.WizardNewWSDLStep

Looks like you have a public class - WizardNewWSDLStep - with a public constructor, yet this constructor requires a
private class - WsdlPanel. The combination is senseless: an outside client could not possibly invoke it. Either make
WsdlPanel public, or make WizardNewWSDLStep's constructor (or the whole class) private.

I'm not sure why this package is even public at all. Does not look like an API to me.
Comment 5 Shivanand Kini 2009-03-11 22:45:00 UTC 
Thanks for the pointers, Jesse. Will remove it from the public package list.
Comment 6 Erno Mononen 2009-03-13 13:38:09 UTC 
So are you fixing this or not?
Comment 7 Jesse Glick 2009-03-13 15:13:48 UTC 
If the committer of a changeset responsible for introducing some regression has not addressed the problem promptly, feel
free to fix it if the fix is obvious (notifying the author of course); if not, simply back it out. 'hg backout' is best
for this. I configure

[defaults]
backout = --merge

since you generally need to merge the backout against current tip anyway.
Comment 8 Erno Mononen 2009-03-13 15:44:11 UTC 
I don't really want clone main again just to fix this, I switched to a team repo and nuked main from my disk. But I 
guess I'll do it eventually if skini doesn't respond since this failure is apparently blocking a commit that I pushed 
to main on Tue(!) from being propagated to main-silver (and hence to team repos).
Comment 9 Shivanand Kini 2009-03-13 19:22:10 UTC 
I will commit the fix by end of today.
Comment 10 Shivanand Kini 2009-03-13 20:49:14 UTC 
Changeset:
http://hg.netbeans.org/main/rev/be7e4ba23dd4
Comment 11 Ivan Sidorkin 2009-04-15 17:10:05 UTC 
verified