This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 159643 - Profiler does not match new UI for actions
Summary: Profiler does not match new UI for actions
Status: RESOLVED FIXED
Alias: None
Product: profiler
Classification: Unclassified
Component: Base (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: J Bachorik
URL:
Keywords: UI
Depends on: 203519
Blocks: 119922
  Show dependency tree
 
Reported: 2009-03-04 23:25 UTC by Jesse Glick
Modified: 2012-05-29 05:36 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2009-03-04 23:25:18 UTC
The UI rule now (issue #119922) is that Run File/Debug File always runs a file as a main(String[]) class, whereas Test
File/Debug Test File always runs a JUnit test (either for the selected file or its associated test). The Profiler does
not seem to have been updated for this. For example, after creating AnagramGame and selecting WordLibraryTest.java, the
Profile Other submenu still shows

[enabled]  Profile Project "Anagram Game"
[enabled]  Profile "WordLibraryTest.java"
[disabled] Profile Test for "WordLibraryTest.java"

whereas it should show e.g.

[enabled]  Profile Project "Anagram Game"
[enabled]  Profile File "WordLibraryTest.java"
[enabled]  Profile Test File "WordLibraryTest.java"

Also will affect automatic projects. Currently in configurePropertiesForProfiling it tries to detect unit tests and
insert junit.textui.TestRunner into the command. It ought not have to do this, because the user's choice of action
should be determining what is run.
Comment 1 J Bachorik 2009-04-27 14:45:48 UTC
Already fixed according to #154810
Comment 2 matusdekanek 2009-06-10 12:27:44 UTC
on 
Product Version: NetBeans IDE 6.7 RC3 (Build 200906100001)
Java: 1.6.0_13; Java HotSpot(TM) Client VM 11.3-b02
System: Windows XP version 5.1 running on x86; Cp1252; en_US (nb)
the 'profile other' submenu is still in direct contrary to what it should be(according to jglick).

Therefore reopening the issue, but lowering the priority.
Comment 3 Jiri Sedlacek 2009-11-08 10:14:51 UTC
Product Version: NetBeans IDE Dev (Build 091106)
Java: 1.6.0_17; Java HotSpot(TM) Client VM 14.3-b01
System: Windows Vista version 6.0 running on x86; Cp1252; en_US (nb)

For selected WordLibraryTest.java the current state is as follows:

  [enabled] Run Project (Anagram Game)
  [enabled] Run File
  [enabled] Test File

  [enabled] Debug Project (Anagram Game)
  [enabled] Debug File
  [enabled] Debug Test File

It doesn't follow the suggested appearance (probably changed again since posted). Moreover, it doesn't seem to follow the same rules (Test File vs. Debug Test File). Could you please point me to the UI specification describing current state? Marking as INCOMPLETE for now - correct appearance is undefined.
Comment 4 Jesse Glick 2009-11-13 12:44:00 UTC
I don't know offhand where HIE keeps their most current UI specifications these days. You will have to ask them. But just based on observing the IDE, and noting the changes that took place in the last few releases:

Run Project (Anagram Game)
Run File [uses main() if available]
Test File [uses JUnit; abbreviation of "run test file"]

Debug Project (Anagram Game)
Debug File
Debug Test File
Attach Debugger...

Currently:

Profile Project (Anagram Game)...
Attach Profiler...
Profile Other >
                Profile Project "Anagram Game"
                Profile "WordLibraryTest.java"
                Profile Test for "WordLibraryTest.java" [disabled]

Clearly the Profile menu is out of synch with Run and especially Debug. Should be:

Profile Project (Anagram Game)...
Profile File
Profile Test File
Attach Profiler...

I.e. delete "Profile Other" submenu, delete redundant version of "Profile Project" action, move single-file actions to main menu (above Attach), make them use regular/junit mode according to action identity rather than selection.
Comment 5 Ondrej Langr 2009-11-26 06:03:15 UTC
> I don't know offhand where HIE keeps their most current
> UI specifications these days.

Most specs can be found from http://ui.netbeans.org (usually with the delay of 1 release, internal up-to-date page will be provided per e-mail request). 

But as of now, there is no UI specification for main menus. These used to be covered by permanent UI specifications, but this process was suspended some time ago. I'm sorry.
Comment 6 Jesse Glick 2010-05-14 20:49:37 UTC
Profile Project (e.g. toolbar button) also does not match the UI of Run or Debug Project. When no main project is set, and there is no other selection, normal actions simply become disabled; Profile Project remains enabled and suggests setting a main project, which we no longer recommend.
Comment 7 Jiri Sedlacek 2012-02-27 14:51:43 UTC
Jarda is now managing the profiler actions.
Comment 8 J Bachorik 2012-04-02 09:41:39 UTC
The actions layout mimics the one of Debug now.

http://hg.netbeans.org/profiler-main/rev/cf681524d222
Comment 9 Quality Engineering 2012-05-29 05:36:54 UTC
Integrated into 'main-golden', will be available in build *201205290002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/f88cdd7ca17b
User: kganfield <kganfield@netbeans.org>
Log: #210715, update profiler topics for main project and #159643, new menu layout